Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-api sentry logs should show stack traces that are sourcemap-aware #367

Closed
gobengo opened this issue Jan 19, 2023 · 3 comments
Closed

Comments

@gobengo
Copy link
Contributor

gobengo commented Jan 19, 2023

Context

#     stack: 'HTTPError: HTTP Request failed\\n' +
#       '    at lN.throw (d1-beta-facade.entry.js:14585:11)\\n' +
#       '    at dN.request (d1-beta-facade.entry.js:14579:135)\\n' +
#       '    at async WN (d1-beta-facade.entry.js:15030:45)\\n' +
#       '    at async Object. (d1-beta-facade.entry.js:15037:132)\\n' +
#       '    at async IB (d1-beta-facade.entry.js:14077:12)\\n' +
#       '    at async AB (d1-beta-facade.entry.js:14065:12)\\n' +
#       '    at async TB (d1-beta-facade.entry.js:14059:42)\\n' +
#       '    at async PO (d1-beta-facade.entry.js:15097:11)\\n' +
#       '    at async ed.fetch (d1-beta-facade.entry.js:9434:17)\\n' +
#       '    at async Object.fetch (d1-beta-facade.entry.js:20183:13)',

Desired Behavior

  • the stack traces in sentry use non-minified variable names, and have sourcemap-aware file paths, not d1-beta-facade.entry.js
@gobengo
Copy link
Contributor Author

gobengo commented Jan 19, 2023

@hugomrdias any ideas on path forward on this? I see in the build script some sourcemap-related stuff is already enabled, and these cloudflare docs aren't very detailed.

Could it be just that we need our release script to have process.env.SENTRY_UPLOAD === 'true'?
https://github.com/web3-storage/w3protocol/blob/main/packages/access-api/scripts/cli.js#L77

@hugomrdias
Copy link
Contributor

hugomrdias commented Jan 19, 2023

this is related to D1 check this PR #368

@gobengo
Copy link
Contributor Author

gobengo commented Apr 5, 2023

Will work on this at #623

@gobengo gobengo closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants