Indent log messages according to the request status #382
Conversation
XVincentX
changed the title
XVincentX
force-pushed
the
feat/logging-indent
branch
from
2bede46 to
b9229ec
Compare
XVincentX
force-pushed
the
feat/logging-indent
branch
from
b1a6b58 to
c898bb9
Compare
|
Let's wait for the big boss |
XVincentX
force-pushed
the
feat/logging-indent
branch
from
d8de79c to
5ab7bbc
Compare
|
Looks great! ONE last comment, I promise :). In the last screenshot above, it looks like the request resulted in an error, is that correct? I suggest that everything related to a request be nested underneath it, including the final error there. As it stands, it's not clear that that error is the final result of the request above it. Does that make sense? |
|
@marbemac That isn't really that easy because the error is detected from the HTTP Server which has the informations to display all the data — but it's on a different level. Indenting only that part might be difficult. Let me try that though, I'll get back to you. |
|
@XVincentX I think we should probably kick this over the line and improve it later if anyone points it out? @marbemac hopefully you're ok with that? I agree this would be nicer but the PR is a big improvement in its own right. We gotta get moving on the e2e test suite. |
|
Yeah, I'm ok merging this — the reason why I did not it's because it's not blocking anybody, so it can stay here. I'd love to see this merged though! |
|
I've implemented the change you requested with an additional property. I have a better idea to implement this in the future but I guess for now let's keep it in this way. |
|
Sorry to hold it up, just seeing this - looks fantastic! Great job @XVincentX 👏 . |
Tracking PR for #379