Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep encoded value if decoding fails. #2387

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

chohmann
Copy link
Contributor

@chohmann chohmann commented Sep 18, 2023

#2376

Summary

Handles when uri decoding binary data fails.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

Using the following curl request:

curl -X POST -H "Content-Type: multipart/form-data" -F "profileImage=@/Users/chelsea/Downloads/1x1.png" "http://127.0.0.1:4010/anything"

the behavior is as follows for the different versions of Prism:

Version 4.14.1
image

Version 5.3.1
image

Local With Fixes
image

@chohmann chohmann requested a review from a team as a code owner September 18, 2023 18:52
@chohmann chohmann requested review from brendarearden and removed request for a team September 18, 2023 18:52
@@ -87,7 +87,14 @@ export function parseMultipartFormDataParams(

export function decodeUriEntities(target: Dictionary<string>) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no content type available when this is called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope.

@chohmann chohmann merged commit aba9bee into master Sep 18, 2023
4 checks passed
@chohmann chohmann deleted the fix/2376-proxy-mode-binary branch September 18, 2023 19:59
@chohmann chohmann mentioned this pull request Sep 19, 2023
@chohmann
Copy link
Contributor Author

This has been released in version 5.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants