-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep encoded value if decoding fails. #2387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chohmann
requested review from
brendarearden
and removed request for
a team
September 18, 2023 18:52
@@ -87,7 +87,14 @@ export function parseMultipartFormDataParams( | |||
|
|||
export function decodeUriEntities(target: Dictionary<string>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no content type available when this is called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope.
daniel-white
approved these changes
Sep 18, 2023
Merged
This has been released in version 5.3.2. |
This was referenced Mar 18, 2024
Closed
This was referenced Mar 18, 2024
Closed
Closed
Merged
This was referenced Apr 29, 2024
Closed
Closed
This was referenced Jul 2, 2024
Merged
Merged
Closed
This was referenced Aug 8, 2024
Merged
Merged
ilanashapiro
pushed a commit
to ilanashapiro/prism
that referenced
this pull request
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2376
Summary
Handles when uri decoding binary data fails.
Checklist
Screenshots
Using the following curl request:
the behavior is as follows for the different versions of Prism:
Version 4.14.1
Version 5.3.1
Local With Fixes