Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validateOutput() when schema contains internal reference #2363

Merged

Conversation

mtjandra
Copy link
Contributor

@mtjandra mtjandra commented Aug 18, 2023

Addresses #2364

Summary

Fixes validateOutput(). Root of the issue is that we forgot to update arguments to validateBody when the following change was applied:

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots
section before creating the PR.

Additional context

Add any other context about the pull request here. Remove this section if there is no additional context.

@mtjandra mtjandra requested a review from a team as a code owner August 18, 2023 17:43
@mtjandra mtjandra requested review from brendarearden and removed request for a team August 18, 2023 17:43
@mtjandra mtjandra force-pushed the fix/validate-output-with-bundle branch from e88d210 to 881e107 Compare August 18, 2023 17:58
@mtjandra mtjandra force-pushed the fix/validate-output-with-bundle branch from 881e107 to abb0406 Compare August 18, 2023 19:09
Copy link
Contributor

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@chohmann chohmann merged commit 8e143e6 into stoplightio:master Aug 25, 2023
4 checks passed
@chohmann chohmann mentioned this pull request Aug 25, 2023
@chohmann
Copy link
Contributor

This was released in version 5.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants