feat: Adding reverse share ability to copy the link (copy) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These 2 PRs are nice additions, thanks! I'll look into it ASAP but as I have my final exams next week it could take some time. |
|
Ok, np, take your time there is no hurry. Good luck for your exams. PS : I also looked to make the 0.16.0 release, using the root package.json scripts, but the |
stonith404
reviewed
Jun 30, 2023
stonith404
reviewed
Jun 30, 2023
|
I've made the requested changes. |
stonith404
approved these changes
Jul 1, 2023
pierrbt
changed the title
stonith404
added a commit
that referenced
this pull request
Jul 10, 2023
* fix: set link default value to random * fix: add auto EOL and add conventional-changelog package * feat: Adding reverse shares' shares a clickable link (#178) * Add clickable link to reverse share's shares * Ran format * Apply suggestions from code review * fix: set link default value to random (#181) * fix: set link default value to random * fix: add auto EOL and add conventional-changelog package * Apply suggestions from code review --------- Co-authored-by: Elias Schneider <[email protected]> * feat: Adding reverse share ability to copy the link (#179) --------- Co-authored-by: Elias Schneider <[email protected]>
stonith404
added a commit
that referenced
this pull request
Jul 10, 2023
* Add clickable link to reverse share's shares * Ran format * Adding copy icon to the reverse share list * Remove console.log * Ran format * Ran format in backend * fix: copy to clipboard spelling * Open the share in another window * feat: Adding reverse shares' shares a clickable link (#178) * Add clickable link to reverse share's shares * Ran format * fix: set link default value to random (#181) * fix: set link default value to random * fix: add auto EOL and add conventional-changelog package * Apply suggestions from code review --------- Co-authored-by: Elias Schneider <[email protected]> * feat: Adding reverse share ability to copy the link (#179) --------- Co-authored-by: Elias Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fetched the token from the backend and then I created the upload link, in order to display a link icon to copy the reverse share's link. I also created a modal to display the link when the context isn't secured. I added this because it was yet impossible to copy the link of the reverse share once it was created. Now you can copy it anytime.
Like this branch is child to the other PR, this may cause some other changes but it should normally works.
This is a preview :