Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth): limited discord server sign-in #346

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

zz5840
Copy link
Contributor

@zz5840 zz5840 commented Nov 26, 2023

close #338

@zz5840 zz5840 marked this pull request as ready for review November 26, 2023 06:36
Copy link
Owner

@stonith404 stonith404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I can't really test it as I don't have an own Discord server but if you've tested it properly we can merge it.

@zz5840
Copy link
Contributor Author

zz5840 commented Nov 26, 2023

@stonith404 Can you build a dev image please? I will test it on my server tomorrow.

@stonith404
Copy link
Owner

@zz5840 Done 👍

@zz5840
Copy link
Contributor Author

zz5840 commented Nov 29, 2023

@stonith404 I've tested it on my server, and it works as expected. Hope we can merge it.

@stonith404
Copy link
Owner

Sorry for the late response. Should I wait for your second PR before creating a new release?

@stonith404 stonith404 merged commit 5f94c72 into stonith404:main Nov 30, 2023
1 check passed
@zz5840
Copy link
Contributor Author

zz5840 commented Dec 1, 2023

@stonith404 Either is fine, but it will take an extra week or two to complete that PR. If you want people to try this feature ASAP, it's better to create a new release.

@stonith404
Copy link
Owner

@zz5840 Great, I've created the release. Thank you for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Limiting Discord login to members of a specific server
2 participants