fix(oauth): github and discord login error #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stonith404 Could you please build a dev image and let them test it? |
|
Great thank you! The dev image is pushed. |
stonith404
reviewed
Nov 10, 2023
|
Great, I'll just wait until we get feedback from the users if it works. Then I'll merge it :) |
|
@stonith404 Can you update the dev image to make changes in 4af97e4 take effect? It's important for locating the error in Microsoft authentication. |
|
@zz5840 👍 Pushed |
|
@stonith404 Maybe they are rest today, I think we should merge this pr and release a new version to fix discord and github first. I'll open a new pr to fix error in Microsoft. |
|
@zz5840 Makes sense. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #322, fixed #302, close #325
Error in Microsoft (#322) still need to be located.