fix: wrong validation of setting max share expiration to 0

stonith404 · Nov 3, 2023 · acc35f4 · acc35f4
1 parent 33742a0
commit acc35f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/frontend/src/components/share/modals/showCreateReverseShareModal.tsx b/frontend/src/components/share/modals/showCreateReverseShareModal.tsx
@@ -72,7 +72,10 @@ const Body = ({
         "",
       ) as moment.unitOfTime.DurationConstructor,
     );
-    if (expirationDate.isAfter(moment().add(maxExpirationInHours, "hours"))) {
+    if (
+      maxExpirationInHours != 0 &&
+      expirationDate.isAfter(moment().add(maxExpirationInHours, "hours"))
+    ) {
       form.setFieldError(
         "expiration_num",
         t("upload.modal.expires.error.too-long", {

diff --git a/frontend/src/components/upload/modals/showCreateUploadModal.tsx b/frontend/src/components/upload/modals/showCreateUploadModal.tsx
@@ -126,6 +126,7 @@ const CreateUploadModalBody = ({
         ) as moment.unitOfTime.DurationConstructor,
       );
       if (
+        options.maxExpirationInHours != 0 &&
         expirationDate.isAfter(
           moment().add(options.maxExpirationInHours, "hours"),
         )