Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-5994 Patch args if they differ from expected #252

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

o-farag
Copy link
Contributor

@o-farag o-farag commented Jul 10, 2023

Description of the change(s):

  • Patch operator args in case of mismatch

Why do we need this PR:

  • Operator can be mistakenly installed without all the correct arguments. Patch operator with correct arguments if this happens.

Issue reference:

Test API/Unit - Success

?       github.com/stolostron/hypershift-addon-operator/cmd     [no test files]
ok      github.com/stolostron/hypershift-addon-operator/pkg/agent       13.536s coverage: 71.2% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/install     175.717s        coverage: 85.8% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/manager     120.072s        coverage: 60.6% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/metrics     0.005s  coverage: 100.0% of statements
?       github.com/stolostron/hypershift-addon-operator/pkg/util        [no test files]

o-farag and others added 4 commits June 7, 2023 14:00
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: o-farag
Once this PR has been reviewed and has the lgtm label, please assign skeeey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Omar Farag <[email protected]>
@o-farag
Copy link
Contributor Author

o-farag commented Jul 10, 2023

/test all

@o-farag o-farag marked this pull request as ready for review July 10, 2023 17:09
@o-farag o-farag changed the title Patch args CM-5994 Patch args if they differ from expected Jul 10, 2023
@o-farag o-farag self-assigned this Jul 10, 2023
@o-farag o-farag changed the title CM-5994 Patch args if they differ from expected ACM-5994 Patch args if they differ from expected Jul 12, 2023
o-farag added 2 commits July 14, 2023 17:30
Signed-off-by: Omar Farag <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.0% 85.0% Coverage
0.0% 0.0% Duplication

@o-farag o-farag requested a review from rokej July 17, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant