-
Notifications
You must be signed in to change notification settings - Fork 26
/
Copy pathhypershift_test.go
1817 lines (1619 loc) · 69.8 KB
/
hypershift_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package install
import (
"context"
"encoding/base64"
"encoding/json"
"fmt"
"io/ioutil"
"os"
"testing"
"time"
"github.com/ghodss/yaml"
"github.com/go-logr/zapr"
hyperv1beta1 "github.com/openshift/hypershift/api/hypershift/v1beta1"
"github.com/prometheus/client_golang/prometheus/testutil"
"github.com/stolostron/hypershift-addon-operator/pkg/metrics"
"github.com/stolostron/hypershift-addon-operator/pkg/util"
"github.com/stretchr/testify/assert"
"go.uber.org/zap"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/wait"
ctrlClient "sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/client/fake"
imageapi "github.com/openshift/api/image/v1"
kbatch "k8s.io/api/batch/v1"
)
const (
hsOperatorImage = "hypershift-operator"
)
func initClient() ctrlClient.Client {
scheme := runtime.NewScheme()
appsv1.AddToScheme(scheme)
corev1.AddToScheme(scheme)
metav1.AddMetaToScheme(scheme)
hyperv1beta1.AddToScheme(scheme)
kbatch.AddToScheme(scheme)
ncb := fake.NewClientBuilder()
ncb.WithScheme(scheme)
return ncb.Build()
}
func initErrorClient() ctrlClient.Client {
scheme := runtime.NewScheme()
ncb := fake.NewClientBuilder()
ncb.WithScheme(scheme)
return ncb.Build()
}
func initDeployObj() *appsv1.Deployment {
return &appsv1.Deployment{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftOperatorName,
Namespace: util.HypershiftOperatorNamespace,
},
}
}
func initDeployAddonObj() *appsv1.Deployment {
deploy := initDeployObj()
deploy.Annotations = map[string]string{
util.HypershiftOperatorNoMCEAnnotationKey: "true",
}
return deploy
}
func initDeployAddonImageDiffObj() *appsv1.Deployment {
deploy := initDeployObj()
deploy.Spec.Template.Spec.Containers = []corev1.Container{
{Image: "testimage"},
}
return deploy
}
type HypershiftTestCliExecutor struct {
}
func (c *HypershiftTestCliExecutor) Execute(ctx context.Context, args []string) ([]byte, error) {
cm := &corev1.ConfigMap{
TypeMeta: metav1.TypeMeta{
Kind: "ConfigMap",
APIVersion: "v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test-cm",
Namespace: "default",
},
Data: map[string]string{"test": "test"},
}
var items []interface{}
items = append(items, cm)
sa := &corev1.ServiceAccount{
TypeMeta: metav1.TypeMeta{
Kind: "ServiceAccount",
APIVersion: "v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test-sa",
Namespace: "default",
},
}
items = append(items, sa)
container := corev1.Container{
Name: "operator",
Image: "",
}
dp := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{
Kind: "Deployment",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "operator",
Namespace: "hypershift",
},
Spec: appsv1.DeploymentSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{container},
},
},
},
}
// Override HS operator image
for i, arg := range args {
if arg == "--image-refs" {
im, err := ioutil.ReadFile(args[i+1])
if err != nil {
return nil, err
}
ims := &imageapi.ImageStream{}
if err = yaml.Unmarshal(im, ims); err != nil {
return nil, err
}
for _, tag := range ims.Spec.Tags {
if tag.Name == hsOperatorImage {
dp.Spec.Template.Spec.Containers[0].Image = tag.From.Name
break
}
}
break
}
}
items = append(items, dp)
out := make(map[string]interface{})
out["items"] = items
return json.Marshal(out)
}
func TestIsDeploymentMarked(t *testing.T) {
cases := []struct {
name string
deploy *appsv1.Deployment
expectedErr string
expectedOk bool
}{
{
name: "no deployment",
deploy: nil,
expectedOk: false,
},
{
name: "unmarked deployment",
deploy: initDeployObj(),
expectedOk: true,
},
{
name: "marked deployment",
deploy: initDeployAddonObj(),
expectedOk: false,
},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
aCtrl := &UpgradeController{
spokeUncachedClient: initClient(),
log: zapr.NewLogger(zapLog),
}
if c.deploy != nil {
assert.Nil(t, aCtrl.spokeUncachedClient.Create(ctx, c.deploy), "")
}
ok := aCtrl.isHypershiftOperatorByMCE(ctx)
assert.Equal(t, c.expectedOk, ok, "ok as expected")
})
}
}
func TestDeploymentExistsWithNoImage(t *testing.T) {
cases := []struct {
name string
deploy *appsv1.Deployment
operatorImage string
expectedErr string
expectedOk bool
}{
{
name: "no deployment, function returns true",
deploy: nil,
expectedOk: true,
},
{
name: "hypershift-operator Deployment, does not have not-by-mce annotation",
deploy: initDeployObj(),
expectedOk: true,
},
{
name: "hypershift-operator Deployment, has not-by-mce = true annotation with identical images",
deploy: initDeployAddonObj(),
expectedOk: false,
},
{
name: "hypershift-operator Deployment, does not have not-by-mce annotation with different images",
deploy: initDeployAddonImageDiffObj(),
operatorImage: "my-new-image02",
expectedOk: true,
},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
ctx := context.Background()
aCtrl := &UpgradeController{
spokeUncachedClient: initClient(),
operatorImage: c.operatorImage,
}
if c.deploy != nil {
assert.Nil(t, aCtrl.spokeUncachedClient.Create(ctx, c.deploy), "")
}
err, ok, _ := aCtrl.operatorUpgradable(ctx)
if len(c.expectedErr) == 0 {
assert.Nil(t, err, "nil when function is successful")
assert.Equal(t, c.expectedOk, ok, "ok as expected")
} else {
assert.Contains(t, err.Error(), c.expectedErr)
}
})
}
}
func TestRunHypershiftRender(t *testing.T) {
ctx := context.Background()
args := []string{
"render",
"--hypershift-image", "quay.io/stolostron/hypershift",
"--namespace", hypershiftOperatorKey.Namespace,
"--format", "json",
}
ctl := UpgradeController{
hypershiftInstallExecutor: &HypershiftLibExecutor{},
}
outputs, err := ctl.runHypershiftRender(ctx, args)
if err != nil {
t.Errorf("Execute hypershift command failed: %v", err)
}
// mapKey format: resourceKind/namespace/name
expectResources := map[string]struct{}{
"PriorityClass//hypershift-control-plane": {},
"PriorityClass//hypershift-etcd": {},
"PriorityClass//hypershift-api-critical": {},
"PriorityClass//hypershift-operator": {},
"Namespace//hypershift": {},
"ServiceAccount/hypershift/operator": {},
"ClusterRole//hypershift-operator": {},
"ClusterRoleBinding//hypershift-operator": {},
"Role/hypershift/hypershift-operator": {},
"RoleBinding/hypershift/hypershift-operator": {},
"Deployment/hypershift/operator": {},
"Service/hypershift/operator": {},
"Role/hypershift/prometheus": {},
"RoleBinding/hypershift/prometheus": {},
"ServiceMonitor/hypershift/operator": {},
"PrometheusRule/hypershift/metrics": {},
"CustomResourceDefinition//clusterresourcesetbindings.addons.cluster.x-k8s.io": {},
"CustomResourceDefinition//clusterresourcesets.addons.cluster.x-k8s.io": {},
"CustomResourceDefinition//clusterclasses.cluster.x-k8s.io": {},
"CustomResourceDefinition//clusters.cluster.x-k8s.io": {},
"CustomResourceDefinition//machinedeployments.cluster.x-k8s.io": {},
"CustomResourceDefinition//machinehealthchecks.cluster.x-k8s.io": {},
"CustomResourceDefinition//machinepools.cluster.x-k8s.io": {},
"CustomResourceDefinition//machines.cluster.x-k8s.io": {},
"CustomResourceDefinition//machinesets.cluster.x-k8s.io": {},
"CustomResourceDefinition//agentclusters.capi-provider.agent-install.openshift.io": {},
"CustomResourceDefinition//agentmachines.capi-provider.agent-install.openshift.io": {},
"CustomResourceDefinition//agentmachinetemplates.capi-provider.agent-install.openshift.io": {},
"CustomResourceDefinition//awsclustercontrolleridentities.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsclusterroleidentities.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsclusterstaticidentities.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsclustertemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsfargateprofiles.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsmachinepools.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsmachines.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsmachinetemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsmanagedmachinepools.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azureclusteridentities.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azureclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azuremachines.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azuremachinetemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmpowervsclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmpowervsimages.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmpowervsmachines.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmpowervsmachinetemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmvpcclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmvpcmachines.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmvpcmachinetemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//kubevirtclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//kubevirtmachines.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//kubevirtmachinetemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//awsendpointservices.hypershift.openshift.io": {},
"CustomResourceDefinition//hostedclusters.hypershift.openshift.io": {},
"CustomResourceDefinition//hostedcontrolplanes.hypershift.openshift.io": {},
"CustomResourceDefinition//nodepools.hypershift.openshift.io": {},
"ConfigMap/hypershift/openshift-config-managed-trusted-ca-bundle": {},
"CustomResourceDefinition//awsmanagedclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azureclustertemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azuremanagedclusters.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azuremanagedcontrolplanes.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//azuremanagedmachinepools.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//ibmpowervsclustertemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//kubevirtclustertemplates.infrastructure.cluster.x-k8s.io": {},
"CustomResourceDefinition//certificaterevocationrequests.certificates.hypershift.openshift.io": {},
"CustomResourceDefinition//certificatesigningrequestapprovals.certificates.hypershift.openshift.io": {},
"CustomResourceDefinition//certificatesigningrequestapprovals.hypershift.openshift.io": {},
}
if len(expectResources) != len(outputs) {
t.Errorf("Expect resource number %d, but got %d", len(expectResources), len(outputs))
}
for _, v := range outputs {
key := fmt.Sprintf("%s/%s/%s", v.GetKind(), v.GetNamespace(), v.GetName())
if _, ok := expectResources[key]; !ok {
t.Errorf("Resource %s is not what we expect", key)
}
// print the expect resource map keys
// t.Errorf("\"%s/%s/%s\":{},", v.GetKind(), v.GetNamespace(), v.GetName())
}
}
func TestRunHypershiftInstall(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
client := initClient()
aCtrl := &UpgradeController{
spokeUncachedClient: client,
hubClient: client,
log: zapr.NewLogger(zapLog),
addonNamespace: "addon",
operatorImage: "my-test-image",
clusterName: "cluster1",
pullSecret: "pull-secret",
hypershiftInstallExecutor: &HypershiftTestCliExecutor{},
}
addonNs := &corev1.Namespace{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.addonNamespace,
},
}
aCtrl.hubClient.Create(ctx, addonNs)
defer aCtrl.hubClient.Delete(ctx, addonNs)
pullSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.pullSecret,
Namespace: aCtrl.addonNamespace,
},
Data: map[string][]byte{
".dockerconfigjson": []byte(`docker-pull-secret`),
},
}
aCtrl.hubClient.Create(ctx, pullSecret)
dp := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{
Kind: "Deployment",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "operator",
Namespace: "hypershift",
},
Spec: appsv1.DeploymentSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "nginx",
Image: "nginx:1.14.2",
Ports: []corev1.ContainerPort{{ContainerPort: 80}},
}},
},
},
},
}
aCtrl.hubClient.Create(ctx, dp)
defer aCtrl.hubClient.Delete(ctx, dp)
extDnsdp := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{
Kind: "Deployment",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "external-dns",
Namespace: "hypershift",
},
Spec: appsv1.DeploymentSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "nginx",
Image: "nginx:1.14.2",
Ports: []corev1.ContainerPort{{ContainerPort: 80}},
}},
},
},
},
}
aCtrl.hubClient.Create(ctx, extDnsdp)
defer aCtrl.hubClient.Delete(ctx, extDnsdp)
// No OIDC secret, but hypershift NS should still be created
err := installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is successful")
// Hypershift NS is created (without OIDc secret)
hypershiftNs := &corev1.Namespace{}
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Name: "hypershift"}, hypershiftNs)
assert.Nil(t, err, "is nil if the hypershift namespace was created")
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InInstallationOrUpgradeBool))
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InstallationOrUpgradeFailedCount))
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.IsAWSS3BucketSecretConfigured))
// Install with OIDC secret
bucketSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftBucketSecretName,
Namespace: aCtrl.clusterName,
},
Data: map[string][]byte{
"bucket": []byte(`my-bucket`),
"region": []byte(`us-east-1`),
"credentials": []byte(`myCredential`),
},
}
aCtrl.hubClient.Create(ctx, bucketSecret)
defer aCtrl.hubClient.Delete(ctx, bucketSecret)
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is successful")
// Hypershift NS is created (with OIDc secret)
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Name: "hypershift"}, hypershiftNs)
assert.Nil(t, err, "is nil if the hypershift namespace was created")
// Check hypershift-operator-oidc-provider-s3-credentials secret exists
oidcSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftBucketSecretName,
Namespace: "hypershift",
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(oidcSecret), oidcSecret)
assert.Nil(t, err, "is nil when oidc secret is found")
assert.Equal(t, []byte(`myCredential`), oidcSecret.Data["credentials"], "the credentials should be equal if the copy was a success")
// Check hypershift-operator-oidc-provider-s3-credentials secret exists in the addon namespace
localOidcSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftBucketSecretName,
Namespace: aCtrl.addonNamespace,
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(localOidcSecret), localOidcSecret)
assert.Nil(t, err, "is nil when locally saved oidc secret is found")
assert.Equal(t, []byte(`myCredential`), localOidcSecret.Data["credentials"], "the credentials should be equal if the copy was a success")
assert.Equal(t, []byte(`my-bucket`), localOidcSecret.Data["bucket"], "the bucket should be equal if the copy was a success")
assert.Equal(t, []byte(`us-east-1`), localOidcSecret.Data["region"], "the resion should be equal if the copy was a success")
// Check hypershift-operator-private-link-credentials secret does NOT exist
plSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftPrivateLinkSecretName,
Namespace: "hypershift",
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(plSecret), plSecret)
assert.NotNil(t, err, "is not nil when private link secret is not provided")
assert.True(t, errors.IsNotFound(err), "private link secret should not be found")
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InInstallationOrUpgradeBool))
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InstallationOrUpgradeFailedCount))
assert.Equal(t, float64(1), testutil.ToFloat64(metrics.IsAWSS3BucketSecretConfigured))
// Check hypershift deployment still exists
err = aCtrl.spokeUncachedClient.Get(ctx, hypershiftOperatorKey, dp)
assert.Nil(t, err, "is nil if the hypershift deployment is found")
// Check pull secret is created in HyperShift Namespace
hsPullSecret := &corev1.Secret{}
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Name: pullSecret.Name, Namespace: hypershiftOperatorKey.Namespace}, hsPullSecret)
assert.Nil(t, err, "is nil if the pull secret in the HyperShift namespace is found")
tr := []imageapi.TagReference{}
tr = append(tr, imageapi.TagReference{Name: hsOperatorImage, From: &corev1.ObjectReference{Name: "quay.io/stolostron/hypershift-operator@sha256:122a59aaf2fa72d1e3c0befb0de61df2aeea848676b0f41055b07ca0e6291391"}})
ims := &imageapi.ImageStream{}
ims.Spec.Tags = tr
imb, err := yaml.Marshal(ims)
assert.Nil(t, err, "expected Marshal to succeed: %s", err)
// Run hypershift install again with image override
overrideCM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftDownstreamOverride,
Namespace: aCtrl.addonNamespace,
},
Data: map[string]string{util.HypershiftOverrideKey: base64.StdEncoding.EncodeToString(imb)},
}
aCtrl.withOverride = true
aCtrl.hubClient.Create(ctx, overrideCM)
defer aCtrl.hubClient.Delete(ctx, overrideCM)
assert.Eventually(t, func() bool {
theConfigMap := &corev1.ConfigMap{}
err := aCtrl.hubClient.Get(ctx, types.NamespacedName{Namespace: aCtrl.addonNamespace, Name: util.HypershiftDownstreamOverride}, theConfigMap)
return err == nil
}, 10*time.Second, 1*time.Second, "hypershift-operator-imagestream configmap was created successfully")
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is sucessful")
assert.Equal(t, float64(1), testutil.ToFloat64(metrics.IsAWSS3BucketSecretConfigured))
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InInstallationOrUpgradeBool))
assert.Equal(t, float64(0), testutil.ToFloat64(metrics.InstallationOrUpgradeFailedCount))
// Run hypershift install again with image override using image upgrade configmap
imageUpgradeCM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftOverrideImagesCM,
Namespace: aCtrl.clusterName,
},
Data: map[string]string{
"hypershift-operator": "quay.io/stolostron/hypershift-operator@sha256:eedb58e7b9c4d9e49c6c53d1b5b97dfddcdffe839bbffd4fb950760715d24244",
},
}
err = aCtrl.hubClient.Create(ctx, imageUpgradeCM)
assert.Nil(t, err, "err nil when config map is created successfull")
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is sucessful")
hsOperatorDeployment := &appsv1.Deployment{}
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Namespace: "hypershift", Name: "operator"}, hsOperatorDeployment)
assert.Nil(t, err, "is nil if hypershift operator is found")
assert.NotNil(t, hsOperatorDeployment.Spec.Template.Spec.ImagePullSecrets, "is not nil if image pull secret is added to the HyperShift operator deployment")
hsOperatorDeployment.Spec.Template.Spec.ImagePullSecrets = nil
err = aCtrl.spokeUncachedClient.Update(ctx, hsOperatorDeployment)
assert.Nil(t, err, "is nil if the hypershift operator is updated successfully to remove the pull secret")
// Install hypershift job failed
go updateHsInstallJobToFailed(ctx, aCtrl.spokeUncachedClient, aCtrl.addonNamespace)
err = aCtrl.RunHypershiftOperatorUpdate(ctx)
assert.NotNil(t, err, "is nil if install HyperShift is sucessful")
assert.Equal(t, "install HyperShift job failed", err.Error())
assert.Equal(t, float64(1), testutil.ToFloat64(metrics.InstallationOrUpgradeFailedCount))
if err := deleteAllInstallJobs(ctx, aCtrl.spokeUncachedClient, aCtrl.addonNamespace); err != nil {
t.Errorf("error cleaning up HyperShift install jobs: %s", err.Error())
}
// Run hypershift install again with pull secret deleted
aCtrl.hubClient.Delete(ctx, pullSecret)
aCtrl.hubClient.Delete(ctx, hsPullSecret)
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is sucessful")
hsOperatorDeployment = &appsv1.Deployment{}
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Namespace: "hypershift", Name: "operator"}, hsOperatorDeployment)
assert.Nil(t, err, "is nil if hypershift operator is found")
assert.Nil(t, hsOperatorDeployment.Spec.Template.Spec.ImagePullSecrets, "is nil if image pull secret is not added to the HyperShift operator deployment")
// Add pull secret back
pullSecret = &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.pullSecret,
Namespace: aCtrl.addonNamespace,
},
Data: map[string][]byte{
".dockerconfigjson": []byte(`docker-pull-secret`),
},
}
err = aCtrl.hubClient.Create(ctx, pullSecret)
assert.Nil(t, err, "is nil if pull-secret is created sucessfully")
// Run hypershift install again with s3 bucket secret deleted
aCtrl.hubClient.Delete(ctx, bucketSecret)
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install HyperShift is sucessful")
// Run a second time to check the upgrade and make sure only one ImagePullSecret is present
err = installHyperShiftOperator(t, ctx, aCtrl, true)
assert.Nil(t, err, "is nil if install TWO of HyperShift is sucessful")
// Create hosted cluster
hcNN := types.NamespacedName{Name: "hd-1", Namespace: "clusters"}
hc := getHostedCluster(hcNN)
err = aCtrl.hubClient.Create(ctx, hc)
assert.Nil(t, err, "err nil when hosted cluster is created successfull")
// Cleanup
// Hypershift deployment is not deleted because there is an existing hostedcluster
err = aCtrl.RunHypershiftCmdWithRetires(ctx, 3, time.Second*10, aCtrl.RunHypershiftCleanup)
assert.Nil(t, err, "is nil if cleanup is succcessful")
// Check hypershift deployment is not deleted
err = aCtrl.spokeUncachedClient.Get(ctx, hypershiftOperatorKey, dp)
assert.Nil(t, err, "is nil if the hypershift deployment exists")
// Check for ImagePullSecret name duplicates
assert.Equal(t, 1, len(dp.Spec.Template.Spec.ImagePullSecrets),
"is 1, when ImagePullSecret array does not contain duplicates")
// Delete HC
err = aCtrl.spokeUncachedClient.Delete(ctx, hc)
assert.Nil(t, err, "err nil when hosted cluster is deleted successfull")
// Cleanup after HC is deleted
err = aCtrl.RunHypershiftCmdWithRetires(ctx, 3, time.Second*10, aCtrl.RunHypershiftCleanup)
assert.Nil(t, err, "is nil if cleanup is succcessful")
// Check hypershift deployment is deleted
err = aCtrl.spokeUncachedClient.Get(ctx, hypershiftOperatorKey, dp)
assert.NotNil(t, err, "is not nil if the hypershift deployment is deleted")
assert.True(t, errors.IsNotFound(err))
// Cleanup again with nil aCtrl is successful
err = aCtrl.RunHypershiftCmdWithRetires(ctx, 3, time.Second*10, aCtrl.RunHypershiftCleanup)
assert.Nil(t, err, "is nil if cleanup is successful")
}
func TestReadDownstreamOverride(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
client := initClient()
aCtrl := &UpgradeController{
spokeUncachedClient: client,
hubClient: client,
log: zapr.NewLogger(zapLog),
addonNamespace: "addon",
operatorImage: "my-test-image",
clusterName: "cluster1",
pullSecret: "pull-secret",
}
_, err := aCtrl.readInDownstreamOverride()
assert.NotNil(t, err, "is not nil when read downstream image override fails")
overrideCM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftDownstreamOverride,
Namespace: aCtrl.addonNamespace,
},
Data: map[string]string{util.HypershiftOverrideKey: base64.StdEncoding.EncodeToString([]byte("test"))},
}
aCtrl.hubClient.Create(ctx, overrideCM)
defer aCtrl.hubClient.Delete(ctx, overrideCM)
f, err := aCtrl.readInDownstreamOverride()
assert.Nil(t, err, "is nil when read downstream image override is successful")
assert.NotNil(t, f, "is not nil when override file is created")
}
func TestRunCommandWithRetries(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
client := initClient()
aCtrl := &UpgradeController{
spokeUncachedClient: client,
hubClient: client,
log: zapr.NewLogger(zapLog),
addonNamespace: "addon",
operatorImage: "my-test-image",
clusterName: "cluster1",
pullSecret: "pull-secret",
}
cmd := func(context.Context) error {
cm1 := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cm1",
Namespace: "default",
},
}
cm2 := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-cm2",
Namespace: "default",
},
}
// 1st entry - create cm1 and return error
// 2nd entry - create cm2 and return nil error
err := aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Name: cm1.Name, Namespace: cm1.Namespace}, cm1)
if err == nil {
aCtrl.hubClient.Create(ctx, cm2)
return nil
}
err = aCtrl.spokeUncachedClient.Get(ctx, types.NamespacedName{Name: cm2.Name, Namespace: cm2.Namespace}, cm1)
if err == nil {
// Should not be called a 3rd time, error
return fmt.Errorf("failed 3rd call")
}
aCtrl.hubClient.Create(ctx, cm1)
return fmt.Errorf("failed 1st call")
}
err := aCtrl.RunHypershiftCmdWithRetires(ctx, 3, 1*time.Second, cmd)
assert.Nil(t, err, "is nil if retry is successful")
}
func TestRunHypershiftInstallPrivateLinkExternalDNS(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
client := initClient()
aCtrl := &UpgradeController{
spokeUncachedClient: client,
hubClient: client,
log: zapr.NewLogger(zapLog),
addonNamespace: "addon",
operatorImage: "my-test-image",
clusterName: "cluster1",
pullSecret: "pull-secret",
hypershiftInstallExecutor: &HypershiftTestCliExecutor{},
}
addonNs := &corev1.Namespace{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.addonNamespace,
},
}
aCtrl.hubClient.Create(ctx, addonNs)
defer aCtrl.hubClient.Delete(ctx, addonNs)
pullSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.pullSecret,
Namespace: aCtrl.addonNamespace,
},
Data: map[string][]byte{
".dockerconfigjson": []byte(`docker-pull-secret`),
},
}
aCtrl.hubClient.Create(ctx, pullSecret)
bucketSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftBucketSecretName,
Namespace: aCtrl.clusterName,
},
Data: map[string][]byte{
"bucket": []byte(`my-bucket`),
"region": []byte(`us-east-1`),
"aws-secret-access-key": []byte(`aws_s3_secret`),
"aws-access-key-id": []byte(`aws_s3_key_id`),
},
}
privateSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftPrivateLinkSecretName,
Namespace: aCtrl.clusterName,
},
Data: map[string][]byte{
"region": []byte(`us-east-1`),
"aws-secret-access-key": []byte(`private_secret`),
"aws-access-key-id": []byte(`private_secret_key_id`),
},
}
externalDnsSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftExternalDNSSecretName,
Namespace: aCtrl.clusterName,
},
Data: map[string][]byte{
"provider": []byte(`aws`),
"credentials": []byte(`private_secret`),
"domain-filter": []byte(`my.house.com`),
"txt-owner-id": []byte(`the-owner`),
},
}
aCtrl.hubClient.Create(ctx, bucketSecret)
defer aCtrl.hubClient.Delete(ctx, bucketSecret)
aCtrl.hubClient.Create(ctx, privateSecret)
defer aCtrl.hubClient.Delete(ctx, privateSecret)
aCtrl.hubClient.Create(ctx, externalDnsSecret)
defer aCtrl.hubClient.Delete(ctx, externalDnsSecret)
dp := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{
Kind: "Deployment",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "operator",
Namespace: "hypershift",
},
Spec: appsv1.DeploymentSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "nginx",
Image: "nginx:1.14.2",
Ports: []corev1.ContainerPort{{ContainerPort: 80}},
}},
},
},
},
}
aCtrl.hubClient.Create(ctx, dp)
defer aCtrl.hubClient.Delete(ctx, dp)
err := installHyperShiftOperator(t, ctx, aCtrl, false)
defer deleteAllInstallJobs(ctx, aCtrl.spokeUncachedClient, aCtrl.addonNamespace)
assert.Nil(t, err, "is nil if install HyperShift is successful")
// Check hypershift-operator-oidc-provider-s3-credentials secret exists
oidcSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftBucketSecretName,
Namespace: "hypershift",
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(oidcSecret), oidcSecret)
assert.Nil(t, err, "is nil when oidc secret is found")
assert.Equal(t, []byte("[default]\naws_access_key_id = aws_s3_key_id\naws_secret_access_key = aws_s3_secret"), oidcSecret.Data["credentials"], "the credentials should be equal if the copy was a success")
// Check hypershift-operator-private-link-credentials secret exists
plSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftPrivateLinkSecretName,
Namespace: "hypershift",
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(plSecret), plSecret)
assert.Nil(t, err, "is nil when private link secret is found")
assert.Equal(t, []byte("[default]\naws_access_key_id = private_secret_key_id\naws_secret_access_key = private_secret"), plSecret.Data["credentials"], "the credentials should be equal if the copy was a success")
// Check hypershift-operator-external-dns-credentials secret exists
edSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftExternalDNSSecretName,
Namespace: "hypershift",
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(edSecret), edSecret)
assert.Nil(t, err, "is nil when external dns secret is found")
assert.Equal(t, []byte(`private_secret`), edSecret.Data["credentials"], "the credentials should be equal if the copy was a success")
installJobList := &kbatch.JobList{}
err = aCtrl.spokeUncachedClient.List(ctx, installJobList)
if assert.Nil(t, err, "listing jobs should succeed: %s", err) {
if assert.Equal(t, 1, len(installJobList.Items), "there should be exactly one install job") {
installJob := installJobList.Items[0]
expectArgs := []string{
"--namespace", "hypershift",
"--oidc-storage-provider-s3-bucket-name", "my-bucket",
"--oidc-storage-provider-s3-region", "us-east-1",
"--oidc-storage-provider-s3-secret", "hypershift-operator-oidc-provider-s3-credentials",
"--aws-private-secret", "hypershift-operator-private-link-credentials",
"--aws-private-region", "us-east-1",
"--private-platform", "AWS",
"--external-dns-secret", "hypershift-operator-external-dns-credentials",
"--external-dns-domain-filter", "my.house.com",
"--external-dns-provider", "aws",
"--external-dns-txt-owner-id", "the-owner",
"--hypershift-image", "my-test-image",
"--platform-monitoring", "OperatorOnly",
"--enable-uwm-telemetry-remote-write",
"--enable-defaulting-webhook",
"--enable-validating-webhook",
}
assert.Equal(t, expectArgs, installJob.Spec.Template.Spec.Containers[0].Args, "mismatched container arguments")
}
}
// Check hypershift-operator-private-link-credentials secret exists in the addon namespace
localPrivateLinkSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftPrivateLinkSecretName,
Namespace: aCtrl.addonNamespace,
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(localPrivateLinkSecret), localPrivateLinkSecret)
assert.Nil(t, err, "is nil when locally saved private link secret is found")
assert.Equal(t, []byte(`us-east-1`), localPrivateLinkSecret.Data["region"], "the region should be equal if the copy was a success")
// Check hypershift-operator-private-link-credentials secret exists in the addon namespace
localExtDnsSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: util.HypershiftExternalDNSSecretName,
Namespace: aCtrl.addonNamespace,
},
}
err = aCtrl.spokeUncachedClient.Get(ctx, ctrlClient.ObjectKeyFromObject(localExtDnsSecret), localExtDnsSecret)
assert.Nil(t, err, "is nil when locally saved external DNS secret is found")
assert.Equal(t, []byte(`my.house.com`), localExtDnsSecret.Data["domain-filter"], "the domain-filter should be equal if the copy was a success")
// Cleanup
err = aCtrl.RunHypershiftCmdWithRetires(ctx, 3, time.Second*10, aCtrl.RunHypershiftCleanup)
assert.Nil(t, err, "is nil if cleanup is succcessful")
}
func TestRunHypershiftInstallEnableRHOBS(t *testing.T) {
ctx := context.Background()
zapLog, _ := zap.NewDevelopment()
client := initClient()
aCtrl := &UpgradeController{
spokeUncachedClient: client,
hubClient: client,
log: zapr.NewLogger(zapLog),
addonNamespace: "addon",
operatorImage: "my-test-image",
clusterName: "cluster1",
pullSecret: "pull-secret",
hypershiftInstallExecutor: &HypershiftTestCliExecutor{},
}
addonNs := &corev1.Namespace{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.addonNamespace,
},
}
aCtrl.hubClient.Create(ctx, addonNs)
defer aCtrl.hubClient.Delete(ctx, addonNs)
pullSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: aCtrl.pullSecret,
Namespace: aCtrl.addonNamespace,
},
Data: map[string][]byte{
".dockerconfigjson": []byte(`docker-pull-secret`),
},
}
aCtrl.hubClient.Create(ctx, pullSecret)
dp := &appsv1.Deployment{
TypeMeta: metav1.TypeMeta{
Kind: "Deployment",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "operator",
Namespace: "hypershift",
},
Spec: appsv1.DeploymentSpec{
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "nginx",
Image: "nginx:1.14.2",
Ports: []corev1.ContainerPort{{ContainerPort: 80}},
}},
},