Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature suggest] Isolation -> comma separated domain patterns #418

Open
crssi opened this issue Jun 8, 2020 · 2 comments
Open

[Feature suggest] Isolation -> comma separated domain patterns #418

crssi opened this issue Jun 8, 2020 · 2 comments

Comments

@crssi
Copy link

crssi commented Jun 8, 2020

Hi @stoically

  1. Could you extend the Domain Pattern in the Isolation -> Per Domain to accept comma separated multiple domains.
  2. Could you add just under Domain Pattern the comma separated list of excepted domains of the Domain Pattern.

For example:
I would always like to open google.*, its subdomain and youtube.com in a new container (<- where trailing * means TLD, like goole.com, google.co.uk...)
But not when Target domain is accounts.google.com or accounts.youtube.com

So the config should say:
Domain Pattern = google.*, *.google.*, youtube.com, *.youtube.com
Domain Pattern Exception = accounts.google.com, accounts.youtube.com

Cheers

@stoically
Copy link
Owner

stoically commented Jun 8, 2020

Sounds like a good suggestion, I think #397 would cover that pretty good as well. A workaround to get that behavior now would be a regexp pattern like this (these also work for exclusion patterns):

/https?://(.+\.)?google\.([^.]+|co\.uk)($|/.*)/

(the co.uk is needed for TLDs with dots in them, so everything without dots like .com is covered)

If I can help with regexp, let me know - could also hop into #tmp:mozilla.org :D

@crssi
Copy link
Author

crssi commented Jun 8, 2020

The regex is not a problem.
ATM I have /^https?:\/\/(?=(.+\.)?(google|youtube)\.([^.]+|co\.uk)\/)((?!accounts\.?(google|youtube)\.([^.]+|co\.uk)\/)).*$/.
But is not really good TLD solution... and Regex is complicated and eye hurting. 😉

@stoically stoically changed the title [Feature suggest] Isolation -> Per Domain [Feature suggest] Isolation -> comma separated domain patterns Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants