Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate/Remove configure in favor of modify_config #31

Closed
jonas-schievink opened this issue May 15, 2021 · 1 comment · Fixed by #36
Closed

Deprecate/Remove configure in favor of modify_config #31

jonas-schievink opened this issue May 15, 2021 · 1 comment · Fixed by #36
Milestone
0.6.0

Comments

@jonas-schievink
Copy link
Contributor

The latter is newer and allows method chaining
@jonas-schievink
Copy link
Contributor Author

jonas-schievink commented May 15, 2021 •
edited
Loading

Maybe this should be called .init() or something, since it enters initialization mode no, modify_config mirrors modify_filters, it's fine

@jonas-schievink jonas-schievink mentioned this issue Jun 19, 2021
Merged
@bors bors bot closed this as completed in e620841 Jun 19, 2021
@jonas-schievink jonas-schievink added this to the 0.6.0 milestone Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Remove Can::configure
1 participant
@jonas-schievink