Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping Radix DropdownMenu.Item with styled breaks keyboard navigation #479

Closed
smhutch opened this issue Mar 12, 2021 · 2 comments
Closed

Comments

@smhutch
Copy link

smhutch commented Mar 12, 2021

Bug report

An issue when combining stitches + radix.

Describe the bug

When wrapping DropdownMenu.Item with styled keyboard navigation is broken upon rendering an Item as an anchor tag.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Sandbox
  2. Compare keyboard navigation between the two examples

Expected behavior

Keyboard navigation should work the same when wrapping Dropdown.Item with styled

System information

  • OS: macOs
  • Browser (if applies): FF / Chrome
  • Version of Stitches: 0.1-canary.18
  • Version of Node.js: 14.15.1

Additional context

Not sure if this belongs here, or in the Radix repo :)

@smhutch
Copy link
Author

smhutch commented Mar 12, 2021

Looks like this is the same issue noted a few days ago: #448

Reading that issue, I now understand what's going on, but unsure how best to fix it 😄

@smhutch
Copy link
Author

smhutch commented Mar 15, 2021

Closing because the title of this issue is inaccurate. It's the same issue as #448.

@smhutch smhutch closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant