Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify CableReadyBroadcastJob queue in initializer #131

Closed
leastbad opened this issue May 25, 2021 · 0 comments · Fixed by #233
Closed

Specify CableReadyBroadcastJob queue in initializer #131

leastbad opened this issue May 25, 2021 · 0 comments · Fixed by #233
Labels
enhancement proposal ruby Pull requests that update Ruby code

Comments

@leastbad
Copy link
Contributor

  1. It seems like the queue_as value in the job class should default to :default but be customizable via the CR initializer.
  2. Following this logic a bit further, what if we added a keyword parameter queue to the broadcast_later and broadcast_later_to method signature that could override?

broadcast_later(queue: "cable_ready")

What do you think, @julianrubisch?
@leastbad leastbad added enhancement proposal ruby Pull requests that update Ruby code labels May 25, 2021
@leastbad leastbad mentioned this issue Jan 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement proposal ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CableReady 5.0 installer stimulusreflex/cable_ready
1 participant
@leastbad