Unnecessary script phase in build

[MrNoodle]

I noticed that JSON.h has conditional compilation based on a hardcoded "1" which is replaced via a shell script build phase. Maybe I'm missing something here, but couldn't you just have it be #ifdef SOMETHING and add -DSOMETHING to the CFLAGS in the build settings for the appropriate targets? Seems less error-prone (especially since I'm seeing another issue concerning the script).

[stig]

I agree that this is a HORRIBLE HORRIBLE HACK. But I couldn't figure out another way that satisfied all these:

• Don't force users to put -DSOMETHING in their CFLAGS
• Works on iPhone / Mac, both when:
  • copied into your app
  • using the static lib / framework

[MrNoodle]

I'm not sure if I follow. The CFLAGS would be set in the targets to build the frameworks/library. Just use #ifndef SOMETHING and if the CFLAGS aren't set (i.e. user copies the files into their own project), then it works fine.

[stig]

I couldn't make it work... Care to make a patch? :)

[MrNoodle]

Hmm, trying it out I see where it breaks down. Though, whenever I copy third party code into my projects, I do tend to stick them into their own dir so the imports would work fine. Not sure if that is something you want to require though.