Build Fails with Node 10

[kbaynes]

Hi Stewart,

Nodegit build is failing with Node 10 on Mac OS 10.13 (High Sierra)

I believe this NodeGit ticket is targeting the root issue, and is under active development: nodegit/nodegit#1490

I then used nvm to get back to 9.8.0, and the build still failed on nodegit. By reading the above ticket, I expected 9.8.0 to succeed, but it did not.

Next, I downgraded to 8.9.0 and was able to build successfully, but then I get a runtime error in Electron:

Uncaught Error: Cannot find module '../build/Release/onig_scanner.node'
at Module._resolveFilename (module.js:485)
at Function.Module._resolveFilename (/Users/kbaynes/Projects/GitHub/contrast/node_modules/electron/dist/Electron.app/Contents/Resources/…:35)
at Function.Module._load (module.js:437)
at Module.require (module.js:513)
at require (internal/module.js:11)
at Object. (/Users/kbaynes/Projects/GitHub/contrast/node_modules/oniguruma/src/oniguruma.js:1)
at Object. (/Users/kbaynes/Projects/GitHub/contrast/node_modules/oniguruma/src/oniguruma.js:105)
at Module._compile (module.js:569)
at Object.Module._extensions..js (module.js:580)
at Module.load (module.js:503)

I can't seem to get past this error. Do you recommend a specific node version? Perhaps 8.9 is too low?

[stewartlord]

Hi, sorry for the slow reply. These version issues are always tricky I find. I am currently running it with 7.10.1. I'm sure we can get it working with a newer version, but I haven't looked into it.

I will leave this issue open and write back when I get it going on a newer release. If you figure it out, please let me know. Thanks!