Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

countdown text area default doesn't display countdown #30

Open
Loque- opened this issue Jul 18, 2018 · 3 comments
Open

countdown text area default doesn't display countdown #30

Loque- opened this issue Jul 18, 2018 · 3 comments
Assignees

Comments

@Loque-
Copy link
Collaborator

Loque- commented Jul 18, 2018

It's a little confusing, could we add the countdown to the component default?

http://localhost:9009/?knob-Children=Back&selectedKind=Forms%2FCountdownTextArea&selectedStory=Component%20default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

@gavinorland
Copy link
Collaborator

What was the decision on this? Wondering if we can close the issue.

@Loque-
Copy link
Collaborator Author

Loque- commented Jul 19, 2018

The issue I had was that I thought it was confusing that by default it does not have a counter - not sure if this is just me or not?

@gavinorland
Copy link
Collaborator

Yes, probably not ideal. Steve suggests adding a maxLength={150} to the default story but maybe not to the component's own default props. The reason being that would then just be an arbitrary number. Trouble is I guess that would mean the story did not actually represent the component default. Argh! Perhaps we had better just leave as is unless there is an appropriate default value - or remove the default story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants