Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace URLs command causes OneNote to hang #800

Closed
stevencohn opened this issue Dec 12, 2022 · 0 comments · Fixed by #801
Closed

Replace URLs command causes OneNote to hang #800

stevencohn opened this issue Dec 12, 2022 · 0 comments · Fixed by #801
Assignees
@stevencohn
Labels
bug Something isn't working released Available in a released installer

Comments

@stevencohn
Copy link
Owner

Describe the bug

  • References/Replace URLs with Images - can cause OneNote to hang
  • References/Replace URLs With Web Page Titles - can cause OneNote to hang

Fix

  • Added User-Agent:OneMore header to all HttpClient calls
  • Added 10 second timeout all URL fetches

Note that some URLs still may not play nicely and cause subsequent URLs to be ignored in the same call
@stevencohn stevencohn added bug Something isn't working unread I have seen it or had time to refine it yet and removed unread I have seen it or had time to refine it yet labels Dec 12, 2022
@stevencohn stevencohn self-assigned this Dec 12, 2022
@stevencohn stevencohn changed the title Hang Replace URLs command causes OneNote to hang Dec 12, 2022
@stevencohn stevencohn linked a pull request Dec 12, 2022 that will close this issue
Added User-Agent:OneMore header to all HttpClient calls. Added 10 sec… #801
Merged
@stevencohn stevencohn added the next-release Addressed but not yet released label Dec 12, 2022
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencohn stevencohn

Labels
bug Something isn't working released Available in a released installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added User-Agent:OneMore header to all HttpClient calls. Added 10 sec… stevencohn/OneMore
1 participant
@stevencohn