Apply style to page will mess with the footnote style

[actforjason]

Before

After

[actforjason]

For latest version 5.3-Beta
The superscript and color of the footnote change after the page style is applied.
Sorry, I'm a little OCD.

[actforjason]

There still be a little problem based on the latest commit #695. The footnote num and "刷新"(refresh) are blue, while after applying the style they become text color. I tried to modify the source code of OneMore but failed.

[stevencohn]

That cannot be fixed. See the comment here.

OneMore is not applying color to the hyperlink but OneNote is and I can't seem to prevent that.

[actforjason]

I don't know much about this field, but I think it should work if put ApplyToHyperlinks() after OneNote Update onenote.UpdatePageContent(), currently ApplyToHyperlinks() seems to be before onenote.UpdatePageContent().

OneMore/OneMore/Commands/Styles/ApplyStylesCommand.cs

Lines 72 to 76 in 902cf77

	if (page.GetPageColor(out _, out _).GetBrightness() < 0.5)
	{
	// hyperlinks require some inline styling
	ApplyToHyperlinks();
	}

OneMore/OneMore/OneNote.cs

Lines 1008 to 1011 in 902cf77

	await InvokeWithRetry(() =>
	{
	onenote.UpdatePageContent(xml, DateTime.MinValue, XMLSchema.xs2013, true);
	});

[stevencohn]

ApplyToHyperlinks and most of the rest of that code just update an in-memory copy of the page XML. It's UpdatePageContent that actually sends that XML back to OneNote to be saved. So it must be the last function call.

[actforjason]

Why can change the color of text through OneNote itself, page doesn't seem to reload, and it does work in its XML.

[stevencohn]

It's just the way Microsoft implement it. The OneNote UI seems to update the page differently than the Interop API that they've published for plugins like OneMore. It's all OneMore has available to use.

[actforjason]

There seems to be a way here.
Change OneNote hyperlink color programmatically

The next workaround works:

1. Add QuickStyleDef to the page with necessary font color.
2. Set the "quickStyleIndex" attribute for hyperlink's parent element (one:OE) to the value of QuickStyleDef.Attribute("index") that we have added to the page.
3. Wrap all other text in that one:OE element with {0}
4. Insert the empty one:T element before the hyperlink

And the hyperlink text color will be like we defined it in QuickStyleDef.

[stevencohn]

No, quickstyles should be preserved for OneNote built-in styles and the OneMore custom styles. You're implying fabricating a quickstyle just to prevent a hyperlink from changing color but that quickstyle wouldn't be related to any style that the user could change via the UI. This is not a good solution.

Ostensibly, this is working as intended. It doesn't look 100% correct, but it's doing what it should do - at least as far as the Interop API allows. There's nothing left to do here.