Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to select a picture, edit it in an external editor (configurable) and save it back #684

Closed
1001QAdotNET opened this issue Oct 20, 2022 · 9 comments · Fixed by #691
Assignees
Labels
feature-request New feature or request released Available in a released installer

Comments

@1001QAdotNET
Copy link

The default OneNote options to edit a picture are rather limited.
Not sure if this was requested before and if this is possible but it would be nice to add the option to select a picture, edit it in an external editor (configurable) and save it back

@stevencohn
Copy link
Owner

What, OneMore's image tools aren't good enough!? I'm offended.

No I'm just kidding. Yes, I've thought about this one too. I often use paint.net as a lightweight but powerful editor. The only catch is the "... and save it back" part of your request. The only way to actually get it back into OneNote is to copy paste it from your external editor, overwriting the original image.

@stevencohn stevencohn added the feature-request New feature or request label Oct 20, 2022
@stevencohn stevencohn self-assigned this Oct 23, 2022
@stevencohn stevencohn linked a pull request Oct 23, 2022 that will close this issue
@stevencohn stevencohn added the next-release Addressed but not yet released label Oct 23, 2022
@stevencohn
Copy link
Owner

Adding Open Image With command with configurable viewer, defaulting to mspaint. You'll need to manually copy and paste the updated image into OneNote but this gets you half-way there.

@1001QAdotNET
Copy link
Author

Ok great, yes I too use paint.net

@1001QAdotNET
Copy link
Author

1001QAdotNET commented Oct 24, 2022

It should be possible to automatically insert the new picture if the user hits Ctrl+A and Ctrl+C while in paint.net (or any combination of keys that copies the edited image to clipboard) and after that OneMore could be able to see when the child process closes (can it see it?) and when that is done access the clippboard programmatically and paste the image in place.
Does this work ?

@stevencohn
Copy link
Owner

Theoretically. But not really. There are way too many failure cases. The simplest of which is that the user subsequently navigates away from the page containing the image; you wouldn't want OneNote jumping back and forth in the middle of what you're doing just to update the image (it can't be done in the background, and no, I'm not interested in using the REST APIs because that is a whole other root ball of problem to sync with the Desktop)

There's also no way to determine if what's on the clipboard is what the updated image or some other misc copied image. So that could result in data loss....

@1001QAdotNET
Copy link
Author

well you do not replace the image edited
just paste it below it and let the user delete the old one if he or she is happy with the new one

@stevencohn
Copy link
Owner

You've already pressed Ctrl+A/Ctrl+C... it's just a Ctrl+V keypress away! :-)

There's quite a bit of coding, error checking required here. The climb isn't worth the view IMO

@1001QAdotNET
Copy link
Author

The climb isn't worth the view I love the metaphor
OK what you implemented is good enough, I will start using it and report back here if I see any issues. No news good news you can close this one if you wish and I can report bugs separately

@stevencohn
Copy link
Owner

Cheers

@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants