Bring playpen.js up to date with @rust-lang/rust@be203ac25836 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copied playpen.js from rust/src/librustdoc/html/static/
|
Thanks for this! There's one issue though: this repo is just a copy of what's in the |
|
I am afraid tools/rustbook in rust-lang/rust does not have its own copy of playpen.js file, but it is referencing playpen.js under librustdoc/html/static of rust-lang/rust. That playpen.js is the latest and no need to update. I found this crate has its own copy of playpen.js under librustdoc/html/static, and it is outdated. This PR will sync the copy to the original in rust-lang/rust. |
|
Just FYI, I filed this issue to rust-lang/rust: Include rustbook binary in the official release artifacts? #34332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized Rust code blocks on the generated HTML book do not have the "Run" button. This was because librustdoc/html/static/playpen.js of this crate is not updated for a while.
I copied the latest playpen.js (rust-lang/rust/src/librustdoc/html/static/playpen.js @ be203ac25836) and verified this solved the problem.
Thanks!