Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Luajit/Lua 5.1 #4

Closed
svipal opened this issue Apr 10, 2020 · 3 comments
Closed

Not compatible with Luajit/Lua 5.1 #4

svipal opened this issue Apr 10, 2020 · 3 comments

Comments

@svipal
Copy link

svipal commented Apr 10, 2020

cmd.c and debug_report_callback make use of the return value of lua_rawgeti, which returns void in above implementations

@stetre
Copy link
Owner

stetre commented Apr 10, 2020

Hi. As stated in the README, it requires Lua >= 5.3. This implies that Lua 5.1 is not supported, and thus neither Luajit.

If that's the only compatibility issue, however, maybe it could be fixed by just adding the lua-compat module.

EDIT: I added lua-compat and while I was at it, I also added it to MoonGLFW. I tried it with Lua 5.1 on Ubuntu and it compiles and loads just fine, but many examples won't work because they use 5.3 features for bitwise operations.
If you use it, keep in mind that the 'unsupported' for Lua < 5.3 still holds, though.

@svipal
Copy link
Author

svipal commented Apr 10, 2020

That's perfect, kudos.Will add it as well to moon nuklear.
Thanks a lot for all these libs btw.

@stetre
Copy link
Owner

stetre commented Apr 10, 2020

I've already added it to MoonNuklear too, as well as to most other libs (just a few hours ago).

@stetre stetre closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants