-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Database #30
Comments
@stemangiola what do you think about this API: get_SingleCellExperiment = function(
.data,
repository = "~/hca_harmonized",
remote_source = NULL,
genes = NULL
) The default behaviour would be to load the data from the We would then need to remove the WEHI default value for I would also like to remove the |
Can For example,
|
I thought about that, but the issue is that users need to be able to specify where the cache lives on their local filesystem. I could instead add a |
we could have the cache_directory as optional argument, if NULL
if NOt NULL
|
You think we should copy the data even if it exists locally? I don't know if most users would want that. e.g. when they Also for the default cache, I was thinking home directory so that it's persistent. Would you rather a temporary directory? |
by default not. Almost nobody will touch the cache parameter. If someone sets it's own cache is because they know what they are doing (probably) and it is an active decision (of course everything will be documented).
Yes home make sense, but at WEHI for example home has a limited space, but you and Julie are for sure the best people to decide this. |
WEHI is a bit of a weird case, but I want this to work well for other institutes too. If I download to |
All this could be even coded in the parameter argument to give transparency, for example get_SingleCellExperiment = function(
repository,
cache_directory = repository |> is_url() |> ifelse( file.path(R.home, ".cache/hca_harmonised"), repository) # Default behaviour
)
|
So the issue is that we need the Either we ignore the local cache when the repository is a local URL, or we go back to my previous suggested API with |
I would prefer this. In this case we can simply do get_SingleCellExperiment = function(
repository,
cache_directory = file.path(R.home, ".cache/hca_harmonised")
) And document that this argument is used only for remote repository. To create the cache directory if doesn't exist you can cache_directory |> dirname() |> dir.create(showWarnings = FALSE, recursive = TRUE) |
The text was updated successfully, but these errors were encountered: