Apply load improvements #4539
Apply load improvements #4539
Conversation
- Use the new function that doesn't access storage, but does emit events - Generate synthetic bucket list with configurable number of entries/ledgers - Tighten the resources estimation
|
Some additional changes the I didn't want to push to this PR just yet - dmkozh#1 |
| mDataEntrySize); | ||
| } | ||
|
|
||
| for (uint32_t i = 0; i < cfg.APPLY_LOAD_BL_SIMULATED_LEDGERS; ++i) |
There was a problem hiding this comment.
Should we separate the command to populate the bucket list from apply-load? The data entry count will need to be communicated between the two runs, but this would allow you to copy the bucket list files and rerun with different parameters instead of waiting for bucket list generation on each run.
There was a problem hiding this comment.
Yeah, I've considered that, but didn't have time for implementation. An alternative to an additional command would be to just only generate the BL if it doesn't contain an expected entry for the maximum id (this has a small footgun if we want to shrink the BL, but I don't think that's a significant issue). This way we won't need to add any additional commands.
Description
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)