bugfix: guard access to mNoOutboundCapacity #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
force-pushed
the
staticAnanlysisFixes
branch
from
dc6b494
to
a1497f9
Compare
marta-lokhova
force-pushed
the
staticAnanlysisFixes
branch
from
e8d57e4
to
b5d69a4
Compare
marta-lokhova
force-pushed
the
staticAnanlysisFixes
branch
from
b5d69a4
to
aa6dddd
Compare
SirTyson
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue discovered by static analysis (data race on
mNoOutboundCapacity). This variable is used to trigger recovery in case flow control gets stuck. In practice, this triggers very rarely (if at all), which is probably why we did not catch this before.