Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test to not load unused setting #4440

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix test to not load unused setting #4440

merged 1 commit into from
Aug 26, 2024

Conversation

sisuresh
Copy link
Contributor

Description

Fix some flaky v22 tests.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh marked this pull request as draft August 26, 2024 20:41
@sisuresh sisuresh force-pushed the flaky-test branch 2 times, most recently from 7894767 to 09eb173 Compare August 26, 2024 20:47
@sisuresh sisuresh changed the title Fix test to not use setting before the right protocol version Fix test to not load unused setting Aug 26, 2024
@sisuresh sisuresh requested a review from dmkozh August 26, 2024 20:50
@sisuresh sisuresh marked this pull request as ready for review August 26, 2024 20:52
@sisuresh sisuresh mentioned this pull request Aug 26, 2024
Open
@dmkozh dmkozh enabled auto-merge August 26, 2024 21:05
@dmkozh dmkozh added this pull request to the merge queue Aug 26, 2024
Merged via the queue into stellar:master with commit f1e0c55 Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisuresh @dmkozh