Fixed assert failure when Soroban tx was sumbitted pre p20 #4414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the TX frame refactor, there is an assertion failure when submitting Soroban TXs pre protocol 20. This was actually a bug before the refactor, where a Soroban TX would fail to get added to the queue with
ADD_STATUS_ERROR
, but the diagnostics would reporttxSUCCESS
. The assert is correct, but the queue now rejects the transaction and setstxNOT_SUPPORTED
. This is TX queue behavior so this won't effect TX replay.Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)