Update overlay survey script with lessons learned during testnet run #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Jul 2, 2024
|
any update on this change? would be nice to land it in v21.2.0 (starts today), so we can use new-style script for pubnet. |
This change makes a few tweaks to the overlay survey script to fix some
small things I noticed after running it on testnet:
* Changes the scripts end condition to depend only on responses, and not
requests. Without this it was possible for the survey script to run
for the full duration of the collecting phase (2 hours) if a node with
more than 25 peers stopped responding after the surveyor recieved the
first set of peers.
* Downgrades the severity of "node already in backlog" messages from
`error` to `debug`. This is an expected condition that I simply forgot
to special-case before.
* Modifies the simulator to occasionally return "node already in
backlog" messages to test the script against that case.
* Adds a `--fast` option to the `simulate` mode that skips any `sleep`
calls. This makes the script much nicer to test.
* Fixes naming of graphml fields to match JSON result fields.
* I did most of this in the V2 script update, but missed a couple
spots.
* Most of this change is in the simulator to support the new field
names.
bboston7
force-pushed
the
survey-script-tweaks
branch
from
6979693
to
9987bdd
Compare
I just responded to your comments and rebased the change |
marta-lokhova
approved these changes
Jul 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes a few tweaks to the overlay survey script to fix some small things I noticed after running it on testnet:
errortodebug. This is an expected condition that I simply forgot to special-case before.--fastoption to thesimulatemode that skips anysleepcalls. This makes the script much nicer to test.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)