Add some trace logging for Soroban #4305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
approved these changes
Jul 19, 2024
| if (isSoroban()) | ||
| { | ||
| CLOG_TRACE(Tx, "Soroban transaction meta: {}", | ||
| xdr::xdr_to_string(meta.getXDR(), "meta")); |
There was a problem hiding this comment.
Nit: use xdrToCerealString
| CLOG_TRACE(Tx, "(excl VM) invokeTimeNsecs: {}, cpuInsn: {}, ratio: {}", | ||
| metrics.mInvokeTimeNsecsExclVm, metrics.mCpuInsnExclVm, | ||
| (float)metrics.mInvokeTimeNsecsExclVm / | ||
| (float)metrics.mCpuInsnExclVm); |
There was a problem hiding this comment.
Nit: C++ Style cast. We also only need to cast one of the numerator or denominator. Finally since this is just logs, why not use double for extra precision?
| CLOG_TRACE(Tx, "(excl VM) invokeTimeNsecs: {}, cpuInsn: {}, ratio: {}", | ||
| metrics.mInvokeTimeNsecsExclVm, metrics.mCpuInsnExclVm, | ||
| (float)metrics.mInvokeTimeNsecsExclVm / | ||
| (float)metrics.mCpuInsnExclVm); |
There was a problem hiding this comment.
Do we need to protect against divide by zero here? Something like
metrics.mCpuInsnExclVm ? metrics.mInvokeTimeNsecsExclVm / (float)metrics.mCpuInsnExclVm : 0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some useful trace logging improvements when I was troubleshooting spikes in the Soroban (time cpu ratio) metrics.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)