Fix rust dependencies on Windows #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
changed the title
MonsieurNicolas
force-pushed
the
fixRustDepsWindows
branch
from
bea20c7
to
f8ed2e3
Compare
dmkozh
reviewed
Oct 5, 2022
src/simulation/LoadGenerator.cpp
Outdated
| @@ -770,8 +770,8 @@ LoadGenerator::createTransactionFramePtr( | |||
| // some_int`. This also would exercise more code paths/logic during the | |||
| // transaction comparisons. | |||
| auto fractionalFeeDistr = | |||
| uniform_int_distribution<uint32_t>(0, ops.size() - 1); | |||
| fee = ops.size() * feeRateDistr(gRandomEngine) + | |||
| uniform_int_distribution<uint32_t>(0, uint32_t(ops.size()) - 1); | |||
There was a problem hiding this comment.
nit: Use static_cast? Using a constructor for cast is a bit confusing.
There was a problem hiding this comment.
agree. fixed
| @@ -48,26 +44,6 @@ encode_b64(T const& v) | |||
| return res; | |||
| } | |||
|
|
|||
| #ifdef ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION | |||
There was a problem hiding this comment.
Just to make sure I understand this correctly: this was just a proof-of-concept change for the bridge and it's not really needed to be here, right?
There was a problem hiding this comment.
correct this was added early on with no use cases. We can add something like that (in a different header) if we need it in the future
There was a problem hiding this comment.
If you want to remove the base64 stuff you might as well cut it out of the rust side too, but fine by me.
graydon
approved these changes
Oct 5, 2022
MonsieurNicolas
force-pushed
the
fixRustDepsWindows
branch
from
f8ed2e3
to
0aaef62
Compare
|
r+ 0aaef62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.