Return contract result value #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
approved these changes
Sep 21, 2022
7 tasks
graydon
force-pushed
the
return-contract-result-value
branch
from
9a0e454
to
0dca385
Compare
|
@MonsieurNicolas and/or @sisuresh this is rebased on the hopefully-ready #3516 so whenever that lands this can go next. |
MonsieurNicolas
force-pushed
the
return-contract-result-value
branch
from
0dca385
to
81f8bf6
Compare
|
r+ 81f8bf6e0ab8269e2d584b36cf387aba66c1df7b |
MonsieurNicolas
force-pushed
the
return-contract-result-value
branch
from
81f8bf6
to
e6ce8d1
Compare
|
r+ e6ce8d1 |
|
(had to run clang-format on it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on the end of #3516 with additional plumbing to pick up the result of a host-function call as described in stellar/stellar-protocol#1307
The only change to look at separately here is the last, 0dca385, which does that new plumbing. The rest should be covered by review of #3516