Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend nomination Monte Carlo simulations to cover asymmetric quorums #4561

Open
bboston7 opened this issue Nov 26, 2024 · 0 comments
Open
Assignees

Comments

@bboston7
Copy link
Contributor

Stellar-core contains a suite of tests that check for fair win probabilities and low timeouts in the new application specific nomination algorithm. These tests use Monte Carlo simulations to generate large numbers of random quorums and simulate nomination for thousands of ledgers. However, these tests assume that quorum sets are symmetric across validators. We should add another series of Monte Carlo simulations that test the following asymmetric cases:

  1. One set of validators has some quorum set A and another has some quorum set B. A and B are almost identical, but B has replaced 1 org in A (or a small number of orgs in A) with a different org.
  2. One set of validators has some quorum set A and another has some quorum set B. A is a strict subset of B, where B contains a few more orgs than A. The number of additional orgs should be small (say, 3) so that the two quorum sets largely overlap.

The tests should focus on timeouts, ensuring that they are infrequent, and that rounds with multiple timeouts are very rare. This is the expected outcome from the new nomination algorithm's design, but simulation will help to confirm our analysis.

@bboston7 bboston7 self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant