Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune core limits to take advantage of freed main thread capacity #4435

Open
3 tasks
marta-lokhova opened this issue Aug 22, 2024 · 1 comment
Open
3 tasks
Assignees

Comments

@marta-lokhova
Copy link
Contributor

With parallelization and other scalability work in-flight, we need to ensure that core is configured correctly such that we can actually take advantage of performance improvements, as well as properly measure the impact. This issue tracks the work to prepare core for high throughput measurements. Here a list of tunable limits identified so far in parallelization performance testing (feel free to append to/edit the list):

  • Block size limit. Currently, both classic and soroban block portions are limited to 5MB each due to the overlay limit of 16MB per message. This isn't too much of a problem for testing classic TPS since those txs are small, but this is an issue when perf testing Soroban (where transactions are KBs in size).
  • Flow control limits. As we free up capacity on the main thread, this means core can now process more transactions at a time, yet our flow control limits are set to batches of 200, causing core to be latency-bound, and not utilizing main thread capacity properly.
  • Tx queue limits. Currently, tx queue limits are 2x of ledger capacity, which might be too restrictive in the scenarios where some transactions get invalidated post apply. This potentially creates a problem when we're not filling blocks to full capacity, and reject transactions prematurely. We should consider increasing transaction queue capacity, as suggested in Consider increasing transaction queue size multiplier to accommodate low Soroban network limits #4108
@marta-lokhova
Copy link
Contributor Author

Worth noting that likely our Soroban TPS tests are currently limited by the block size limit (cc @bboston7)

@marta-lokhova marta-lokhova self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant