Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider increasing transaction queue size multiplier to accommodate low Soroban network limits #4108

Open
marta-lokhova opened this issue Dec 21, 2023 · 0 comments

Comments

@marta-lokhova
Copy link
Contributor

Currently, the tx queue stores 2 ledgers worth of Soroban transactions, and rejects any new cheaper transactions submitted to core. As noted by @dmkozh, this is quite limiting when the network limits are very low (for example, phase 1 limits only allow 1 large Soroban tx per ledger).

We may want to increase the multiplier to allow more transactions to enter the transactions queue, in hopes of them all eventually making them into the ledger. This doesn't fundamentally solve the problem, as transactions are still at risk of being dropped due to low ledger limits (we only keep transactions around for 4 ledgers), but this change may slightly increase chances of transactions getting in, and potentially improve developer experience.

One thing to keep in mind is that rejecting a transaction right away provides better user experience, as the user immediately knows the fee that's needed to get into the ledger. Increasing the multiplier may cause core to drop transactions on the floor, without any useful feedback to the user, creating confusion. Marking this issue as "discussion" as I'm curious to hear what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@marta-lokhova and others