Clarify contract in the comment, harden BucketApplicator

stellar · Sep 5, 2024 · b5d69a4 · b5d69a4
1 parent a1497f9
commit b5d69a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/bucket/BucketApplicator.h b/src/bucket/BucketApplicator.h
@@ -28,7 +28,7 @@ class BucketApplicator
     size_t mCount{0};
     std::function<bool(LedgerEntryType)> mEntryTypeFilter;
     std::unordered_set<LedgerKey>& mSeenKeys;
-    std::streamoff mUpperBoundOffset;
+    std::streamoff mUpperBoundOffset{0};
     bool mOffersRemaining{true};
 
   public:

diff --git a/src/overlay/Peer.h b/src/overlay/Peer.h
@@ -247,6 +247,8 @@ class Peer : public std::enable_shared_from_this<Peer>,
     // with methods running on background threads might access this
     // unsynchronized state. All methods that access this private state should
     // assert that they are running on the main
+    // IOW, all methods using these private variables and functions below must
+    // synchronize access manually
   private:
     PeerState mState;
     NodeID mPeerID;