Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn emoji looks sad #1576

Closed
leighmcculloch opened this issue Aug 29, 2024 · 4 comments
Closed

warn emoji looks sad #1576

leighmcculloch opened this issue Aug 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

What version are you using?

main

What did you do?

Screenshot 2024-08-29 at 9 47 35 PM

What did you expect to see?

A warn emoji that looks like this: ⚠️

What did you see instead?

A warn emoji that looks less colorful.

@leighmcculloch leighmcculloch added the bug Something isn't working label Aug 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Aug 29, 2024
@leighmcculloch
Copy link
Member Author

The command I'm using to triggering the warn emoji is in #1571 and not merged yet. But the warn emojis shows up elsewhere in the app, and this issue isn't dependent on #1571.

@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Aug 30, 2024
@janewang
Copy link
Contributor

janewang commented Sep 3, 2024

Leigh will check terminal font

@fnando
Copy link
Member

fnando commented Sep 3, 2024

Looks like this is a VScode terminal issue. The fix is to add the emoji font to the font stack.

microsoft/vscode#32840

In my case, I had to actually add this:

"terminal.integrated.fontFamily": "'JetBrainsMonoMedium Nerd Font Mono', 'Apple Color Emoji'",

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Sep 3, 2024

I changed my font to the following and it fixed the issue:

"editor.fontFamily": "'Fira Code', 'Apple Color Emoji', monospace",

@leighmcculloch leighmcculloch closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@github-project-automation github-project-automation bot moved this from Todo (Ready for Dev) to Done in DevX Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants