Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a token interface for the SAC. #945

Open
sisuresh opened this issue Jan 26, 2023 · 1 comment
Open

Add a token interface for the SAC. #945

sisuresh opened this issue Jan 26, 2023 · 1 comment

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Jan 26, 2023

There have been some questions around if functions like clawback and set_admin (some context around set_admin) should be included in the token interface. We should add another interface in the SDK that users should implement, and leave the existing one in there if you want to use SAC specific admin functionality. My thoughts on this from here are quoted below -

I have been thinking about if there are any admin methods in the interface that should be pulled out because they're specific to Stellar assets and can be implemented as an extension to the interface (clawback() is a good example of this). I can see the argument for removing set_admin as well since administrative type methods are typically used as one-off calls (and are more likely to require custom logic/function signature). Custom tokens shouldn't have to implement methods that they don't need either. The EIP-20 interface is actually quite bare, which makes it easier to implement tokens.

Discord thread with a discussion about this here.

@sisuresh sisuresh transferred this issue from stellar/rs-soroban-env May 15, 2023
@sisuresh sisuresh changed the title Consider removing admin level methods from the token interface Add a minimal token interface in the sdk similar to ERC-20. Jun 2, 2023
@sisuresh
Copy link
Contributor Author

sisuresh commented Jun 28, 2023

The interfaces were split in #1012. We still need to provide a single interface to interact with the SAC. This can be done by exposing a trait that combines the Client and AdminClient.

@sisuresh sisuresh reopened this Jun 28, 2023
@sisuresh sisuresh changed the title Add a minimal token interface in the sdk similar to ERC-20. Add a token interface for the SAC. Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@sisuresh and others