Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: default to max limit for trustlines #1265

Closed
3 tasks
ire-and-curses opened this issue May 10, 2019 · 1 comment
Closed
3 tasks

txnbuild: default to max limit for trustlines #1265

ire-and-curses opened this issue May 10, 2019 · 1 comment
Assignees
@poliha
Labels
txnbuild 2nd-generation transaction build library for Go SDK

Comments

@ire-and-curses
Copy link
Member

ire-and-curses commented May 10, 2019 •
edited
Loading

At the moment, attempting to build a txnbuild.ChangeTrust operation without a trustline limit will fail with a low level parse error.

The JS SDK defaults to the max limit (int64) if no amount is specified. We should

  • - add a MaxTrustlineLimit const
  • - default to this value if no Limit is specified
  • - document this behaviour in the GoDoc
@ire-and-curses ire-and-curses added the txnbuild 2nd-generation transaction build library for Go SDK label May 10, 2019
@poliha poliha self-assigned this May 13, 2019
@poliha poliha mentioned this issue May 13, 2019
Merged
@ire-and-curses ire-and-curses added this to the txnbuild v1.2.0 milestone May 13, 2019
@ire-and-curses
Copy link
Member Author

Implemented in #1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poliha poliha

Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ire-and-curses @poliha