Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: Validate requird struct args before building #1041

Closed
ire-and-curses opened this issue Mar 21, 2019 · 0 comments · Fixed by #1707
Closed

txnbuild: Validate requird struct args before building #1041

ire-and-curses opened this issue Mar 21, 2019 · 0 comments · Fixed by #1707
Assignees
@ire-and-curses
Labels
txnbuild 2nd-generation transaction build library for Go SDK

Comments

@ire-and-curses
Copy link
Contributor

If you call BuildXDR() with critical fields unset, you get an ugly runtime pointer dereference error.

Validate the presence of required struct fields before trying to access them for building. Raise a descriptive error indicating the necessary struct fields.
@ire-and-curses ire-and-curses added sdk txnbuild 2nd-generation transaction build library for Go SDK labels Mar 21, 2019
@ire-and-curses ire-and-curses self-assigned this Apr 3, 2019
@poliha poliha self-assigned this Jul 24, 2019
@poliha poliha added this to the horizonclient 1.4.0 milestone Jul 31, 2019
@poliha poliha removed this from the horizonclient 1.4.0 milestone Aug 8, 2019
@poliha poliha mentioned this issue Sep 4, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ire-and-curses ire-and-curses

Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txnbuild: validate operation structs poliha/go
2 participants
@ire-and-curses @poliha