Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit_options doesn't work with multiple arguments #74

Closed
Caellian opened this issue May 8, 2020 · 1 comment
Closed

commit_options doesn't work with multiple arguments #74

Caellian opened this issue May 8, 2020 · 1 comment

Comments

@Caellian
Copy link

Caellian commented May 8, 2020

Version of the Action
v4.1.2

Describe the bug
commit_options option treats space separated arguments as one.

To Reproduce
Use commit_options with multiple arguments like described in README.
I tried both --no-verify --signoff and '--no-verify --signoff' although there should be no difference.
I also tried passing a sequence:

commit_options:
  - '--no-verify'
  - '--no-verify'

but that didn't work either.

Expected behaviour
Arguments to be passed individually instead of being treated as one.
Either the example is wrong and a yaml list should be passed.

Used Workflow

name: clang-format
env:
  CI_BUILD: true

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  format:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          submodules: true
      - name: Install clang-format
        run: |
          sudo apt-get update -m
          sudo apt-get install clang-format-9
      - name: Run clang-format
        run: clang-format-9 -i $(find -iregex "./src/.*\.[hc]pp" -or -iregex "./include/.*\.[hc]pp" -or -iregex "./test/.*\.[hc]pp" -or -iregex "./fuzz_test/.*\.[hc]pp")
      - name: Install cmake-format
        run: |
          sudo apt-get install python3
          sudo pip install --upgrade pip
          sudo pip install cmake-format
      - name: Run cmake-format
        run: cmake-format -i -c ".cmake-format.yaml" $(find -iregex "./.*\.cmake" -or -name "CMakeLists.txt")
      - uses: stefanzweifel/[email protected]
        with:
          commit_message: Applied automatic formatting
          branch: ${{ github.head_ref }}
          commit_options: --no-verify --signoff
          commit_user_name: Formatting Bot

Also, here's the failed action for convenience.

@stefanzweifel
Copy link
Owner

Hi,

This problem has been fixed in #64 and release in v4.1.5. Please update to v4.1.5 or even better the latest version (v4.1.6).

Also see our changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants