Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push without branch broken in 4.1 but works in 3.0.0 #53

Closed
timwhite opened this issue Mar 13, 2020 · 2 comments
Closed

Push without branch broken in 4.1 but works in 3.0.0 #53

timwhite opened this issue Mar 13, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@timwhite
Copy link

Version of the Action
v4.1.0

Describe the bug
The push when no branch is specified just doesn't make it back to Github in V4.1.0 while it does work in v3.0.0

To Reproduce
Steps to reproduce the behaviour:

  1. Using v4.1.0 I expect after the commit the push back to the originating branch to occur. Instead I get an "everything is up to date" message.
    https://github.com/TSSF-Asia-Pacific/communityobedience/runs/506933775?check_suite_focus=true#step:4:21

Expected behaviour
Instead of everything is up to date, it should show that it pushed back to the branch, like it does in v3.0.0
https://github.com/TSSF-Asia-Pacific/communityobedience/runs/506938310?check_suite_focus=true#step:5:19

@stefanzweifel stefanzweifel self-assigned this Mar 14, 2020
@stefanzweifel stefanzweifel added the bug Something isn't working label Mar 14, 2020
@stefanzweifel
Copy link
Owner

Hi Tim,

Thanks for pointing this out! Can confirm that the changes made in v4.1.0 no longer push the commit back to the right branch.

v4.0.0 still works as expected though.

@stefanzweifel
Copy link
Owner

Your issue has been fixed in #54. I've also tagged a new version: v4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants