Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translations incomplete #569

Closed
RuggeroFabbiano opened this issue Aug 25, 2023 · 5 comments · Fixed by #594
Closed

Italian translations incomplete #569

RuggeroFabbiano opened this issue Aug 25, 2023 · 5 comments · Fixed by #594

Comments

@RuggeroFabbiano
Copy link
Contributor

Hello

There are a couple of translations missing in the Italian locale, that make the form error message appear in the default language when a wrong telephone number is submitted.

Happy to contribute if needed.

@francoisfreitag
Copy link
Collaborator

Yes please! You should be able to edit https://github.com/stefanfoulis/django-phonenumber-field/blob/main/phonenumber_field/locale/it/LC_MESSAGES/django.po on GitHub. The msgid is the original version of the string, and msgstr is the corresponding translation.

If you’re not confortable generating the .mo file, no worries, I’ll do it on the PR (be sure to allow edits from maintainers).

Thanks in advance ⭐

@francoisfreitag
Copy link
Collaborator

(note that strings marked as fuzzy could use an update as well)

@RuggeroFabbiano
Copy link
Contributor Author

Sorry for the late reply, have been quite busy 😅
No worries, I'm quite used to how it works. I should be able to do it soon!

@RuggeroFabbiano
Copy link
Contributor Author

I generated the .mo file, but I wasn't able to commit it due to them be Git-ignored.

@francoisfreitag
Copy link
Collaborator

francoisfreitag commented Dec 29, 2023

Yes, I changed the release process to generate the MO files, so that git only follows the .po from now on. I didn’t think to come back to this PR.

Corresponding PR: #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants