Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RxMarkdown with Markwon #549

Closed
14 of 15 tasks
quthla opened this issue Apr 4, 2019 · 58 comments · Fixed by #1016
Closed
14 of 15 tasks

Replace RxMarkdown with Markwon #549

quthla opened this issue Apr 4, 2019 · 58 comments · Fixed by #1016

Comments

@quthla
Copy link
Contributor

quthla commented Apr 4, 2019

Some tasks left, but i think we are already on a good way

  • Syntax Highlighting (needs another lib i think)
  • Different Header levels do not work properly yet in edit mode
  • Fix coloring on search
  • Check if we can prevent selection of tasks when toggling checkboxes
  • Check if a checkbox can be toggled when clicking on the checkbox directly (not the text)
  • Check external links, especially fix or remove links in checkboxes (affects maybe only edit mode?)
  • Make sure that internal links work
  • Styling (should be as close as possible to the webapp)
    • Codeblocks should always use monospace font
    • Closing fence of cosing blocks are different from opening blocks
  • Extract plugins where possible to make them reusable
  • Centralize the configurations
    • Respect monospace font setting
    • Respect font size setting
  • Use Markwon on all places where previously RxMarkdown has been used (e. g. widgets)
@stefan-niedermann

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@quthla

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@quthla

This comment has been minimized.

@tnyeanderson

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@alensiljak

This comment has been minimized.

@lenzls lenzls mentioned this issue Dec 30, 2019
@lenzls

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@stefan-niedermann
Copy link
Member

Yes i contacted them for various topics like checkboxes and got good responses so far.
If you checked out the PR you will notice that basic editing is already possible.

Major issue remains my free time which i have to split for various open source projects (like the Deck Android app). Therefore again: You will need to stay patient or contribute some code (remaining topics are documented at the top of this issue) 🙂

@nextcloud nextcloud deleted a comment from larena1 Jul 13, 2020
@fabianski7

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@fabianski7

This comment has been minimized.

@larena1
Copy link

larena1 commented Oct 7, 2020

Any news here @stefan-niedermann?

@stefan-niedermann
Copy link
Member

I am currently working on a modernization of the architecture (e. g. migrating from SQLiteOpenHelper to Room) to clean up the code and make maintenance easier.

When i am working on the editor, i will post updates here, and if i don't work on the editor, i obviously won't post anything. Everyone is always welcome to join the development and work on the branch. I will happily support where i can if someone wants to pick up this.

I will lock the conversation for now, since the issue is getting quite unreadable with all the comments which don't provide any news compared to the checklist on the very top.

@nextcloud nextcloud locked and limited conversation to collaborators Oct 7, 2020
@stefan-niedermann
Copy link
Member

Some updates for everyone who subscribed to this issue:

Today we started rolling out the Deck Android app 1.13.2 which is kind of a big deal for the Notes app in general and especially this issue. Why? Well, the new Deck version features a new markdown editor for the description field.

This editor is based on Markwon and we used the Deck app as a testing environment here: The new editor can improve over the time and as soon as it reaches the same function level as the Notes app has today, we can easily reuse it for Notes.

Today we made a very big step because the basic editoe is working, it already has auto continuation for lists and checkboxes and we are currently working on the context based formatting which the Notes app also has today. As soon as this has been implemented, we can pull the editor over to the Notes app. For the viewer we are still missing support for togglable checkboxes as well as proper link handling. But also here we will implement and test the Markwon based viewer in the Deck app and can pull it over as soon as it is feature complete.

Thank you for the patience. Everyone who is interested in contributing some code: Just ping me in the linked pull request or in the linked blog post of the help forum.

@stefan-niedermann
Copy link
Member

Hey there 👋

I have just published v2.18.0 at the Play Store beta channel. This version features the new Markwon based editor. Basically it should be way more reliable (especially when handling lists) than the old editor.
It also should be available on F-Droid in a few days. I am very grateful for each feedback to the new editor of this new version (Just open separate new issues).

We are continuing to work on the viewer which is basically only missing "togglable checkboxes" and then can replace the old RxMarkdown based viewer.

@nextcloud nextcloud unlocked this conversation Dec 21, 2020
@jakobroehrl

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@stefan-niedermann
Copy link
Member

Quite a long time, but finally i merged the new Markwon based preview mode to the master branch and released v2.19.0. It will be available on the Play Store beta channel and on F-Droid in a few days.

Thank you all for your patience, i hope you will do excessive testing and report any issues here, so we can finally push it to the Play Store release channel soon. 🙂

👀 Screenshots

1 2 3
checkboxes images tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.