Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comment indicator #928

Closed
2 of 4 tasks
christianlupus opened this issue Apr 12, 2021 · 11 comments
Closed
2 of 4 tasks

Missing comment indicator #928

christianlupus opened this issue Apr 12, 2021 · 11 comments

Comments

@christianlupus
Copy link

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

There is a small indicator for each card that has comments attached to it. Unfortunately, this is not shown all the time.

Steps to reproduce the behavior:

  1. Prepare a board with a few cards, some with some comments and some without
  2. Take a vanilla installation of the android app and create/setup an account within
  3. After sync look at the various cards on the board
  4. Close the app, wait a bit of time, do a few more comments
  5. Reopen the app and trigger sync
  6. Repeat step 3

Expected behavior

All cards having comments attached are showing a small icon both in steps 3 + 6.

Actual behavior
The cards with comments are showing the icon in step 3 as expected.
In step 6 no icon is shown. I have to manually iterate over all cards to see if there are any important comments.

Versions

  • Nextcloud: 21.0.1
  • Nextcloud Deck: 1.3.2
  • Nextcloud Android: 3.16.0RC2
  • Nextcloud Android Deck: 1.16.1

Smartphone (please complete the following information):

  • Device: Xiaomi Mi A2 Lite
  • Android-Version: 10
  • App-Store:
    • Google Play Store
    • Google Play Store (Beta channel)
    • F-Droid
    • Huawei AppGallery

I am unsure about the beta channel of the google play store. I think the NC main app is in beta version.

Stacktrace
No error is visible so no strack trace

@stefan-niedermann
Copy link
Owner

Hi @christianlupus

just to make sure i understand you correctly: The comments indicator

  • is missing on all cards
  • is missing on one card
  • is not up to date (e. g. shows the wrong number) on one or all cards?

Further questions:

  • Can you observe the described behavior also for the attachments indicator?
  • When do the icons reappear? After closing the app and restarting it? Performing a synchronization? ...?

@stefan-niedermann
Copy link
Owner

Might be related to (or even caused by) nextcloud/deck#2952 - can you please check whether you are able to see the comment indicators in the Web UI in those cases?

@stefan-niedermann
Copy link
Owner

ping @christianlupus

@christianlupus
Copy link
Author

Hi, @stefan-niedermann. Sorry for the late answer, had some pressing issues in my day job (and BTW my phone was broken).

The comment indicator was once shown (but I did not check it there, was just glad the cards were marked). Now, no cards show any marks regarding comments.
Just to make sure: The marking should be persistent if there are any comments or should it only show new comments?

Regarding attachments: I have not yet tried. I need to set up a test board and play with it (I do not want to clutter the production board).

The icons were there (again?) after I had to reconnect the app (removing the app's account and reapplying) as of #829.

The issue nextcloud/deck#2952 was opened by me. In fact, I found the issue in the web app, and soon after, I saw that the Android app seemed not to be affected as far as I remember.
Nevertheless, the next day (not 100% sure how long) the icons in the Android app were invisible as well. Therefore I asked above if this is a feature instead of a bug (if the icon just signals new/unread comments).

If this helps, I could give you temporary access to the board that caused the problems. Ping me if you want this.

@stefan-niedermann
Copy link
Owner

The marking should be persistent if there are any comments or should it only show new comments?

The indicator should always be there

It would be awesome if you could check whether the comments are actually in thr android apps database: If the indicator is not shown again, please go completely offline and open a card - Check if the full comments are visible there or also missing.

A test account with a shared play board would be awesome, so we can try to reproduce this issue :) (credentials to [email protected]) - thanks for the offer!

@stefan-niedermann
Copy link
Owner

@christianlupus did you already had some time to test

[...] if you could check whether the comments are actually in the android apps database: If the indicator is not shown again, please go completely offline and open a card - Check if the full comments are visible there or also missing.

@christianlupus
Copy link
Author

@stefan-niedermann I tried to reproduce but was no longer able to do so. I had updated both the server app and (I think) the android app in the meantime, the issue might well be gone in the current release.

If you do not mind, I will close here as I can no longer reproduce it. If it reappears, I will reopen/comment again.

@stefan-niedermann
Copy link
Owner

Sure, sounds good :) Thank you for the feedback.

@mortee
Copy link

mortee commented Jan 27, 2022

I can reproduce a variant of this in app version 1.20.0. Apparently, the icon indicating the presence of a description only shows up when at least one is also present of attachments, comments or assignee.

@stefan-niedermann
Copy link
Owner

@mortee this behavior is by intention. The icon would cause the app to need a second line (for a consistent) for each card which wastes space for quite a little benefit.

@mortee
Copy link

mortee commented Jan 27, 2022

I see, my bad. I'm fine with this, just didn't know it wasn't a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants