Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feature request, ci ] Test only changed packages and those that transitively depend on change at PRs to the DB #91

Open
buzden opened this issue Feb 8, 2023 · 1 comment

Comments

@buzden
Copy link
Collaborator

buzden commented Feb 8, 2023

I have no idea of how hard is it implement, but I've found the following:

When I propose to add some libraries to the collection, the whole collection is rechecked. So, when any library in the collection fails to build, the whole result of CI check for the PR is considered to be bad.

What I propose is to try to narrow the set of checked packages to changed/added packages and those packages that are anyhow influenced by those changes ones. This would lead to more adequate results of CI tests upon PRs.

@stefan-hoeck
Copy link
Owner

I'll have to think about this. Should be possible to in pack-admin compare HEAD.toml of the PR against HEAD.toml of the main branch and only run the newly added packages. This will be harder if some packages are deleted.

On the other hand, I'm not sure this is worth the trouble. We always can rerun the checks once the package collection builds again. I'm planning to drop another note to the package maintainers of the currently failing packages over the weekend. If they require more time to fix this, the failing packages will be temporarily commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants