Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff of a large file fails with "Error: stdout maxBuffer exceeded" #116

Closed
madakk opened this issue Dec 16, 2017 · 3 comments
Closed

Diff of a large file fails with "Error: stdout maxBuffer exceeded" #116

madakk opened this issue Dec 16, 2017 · 3 comments
Assignees

Comments

@madakk
Copy link

madakk commented Dec 16, 2017

Apparently the call to p4.exe print -q fails. The file in question is 272kb.

Edit: To clarify this only happens when editing an open file via the changelist. If I manually diff a file it seems to call p4.exe print -q -o to a tmp file, which works fine.

@stef-levesque
Copy link
Owner

The default value for perforce.maxBuffer is 204800 (200KB)
You can increase it to your needs in your user profile. I personally set it to 1MB on large projects:

{ 
  "perforce.maxBuffer": 1048576
}

I might increase the default value on the next release

@madakk
Copy link
Author

madakk commented Dec 17, 2017

Thanks for the response, that's perfect.

Perhaps a good thing to do would be to at least catch this error and report it to the user, as it seems to just hang there and do nothing and without examining the output log you'd have no clue that an error had happened.

@stef-levesque
Copy link
Owner

The error should display in the status bar, next to the p4 icon, for a few seconds, although it might not be that much noticeable.

It was previously displaying as a message box next to the command palette, but people found it annoying. I should probably priorities some error messages, and implement a mechanism to individually ignore them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants