Hover broken in 1.16.0-insider

[stef-levesque]

The hover message is now broken in the 1.16.0-insider version of VSCode. The 1.15.1 version is fine.

The hover content is defined in extension.ts and the coloration from hexdump.tmLanguage

return new vscode.Hover( {language: 'hexdump', value: "content"} );

@jrieken @dbaeumer
Could this come from microsoft/vscode#29076 ?
Is it possible that Hover doesnt take extention .tmLanguage anymore ?
Anyway to reproduce the same colorization with a MarkdownString ?

[jrieken]

Thanks, I will investigate. We did refactor some bits but everything should still work...

[stef-levesque]

fwiw, it seems to always assume a MarkedString, or MarkdownString, whatever the language set.

For example, this display with the hexdump color syntax:

content = '```hexdump\n' + content + '\n```\n';
return new vscode.Hover( {language: 'plaintext', value: content} );

[jrieken]

Yeah, it's is fixed on master. The problem is that the new MarkdownString has value and isTrusted and that this function also accepts a MarkedString

export function isMarkdownString(thing: any): thing is IMarkdownString {
	if (thing instanceof MarkdownString) {
		return true;
	} else if (typeof thing === 'object') {
		return typeof (<IMarkdownString>thing).value === 'string'
			&& (typeof (<IMarkdownString>thing).isTrusted === 'boolean' || (<IMarkdownString>thing).isTrusted === void 0);
	}
	return false;
}

[stef-levesque]

Now fixed in 1.16.0-insider