Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a ~15MB file #22

Closed
rodrigokiller opened this issue Mar 16, 2017 · 5 comments
Closed

Open a ~15MB file #22

rodrigokiller opened this issue Mar 16, 2017 · 5 comments
Assignees

Comments

@rodrigokiller
Copy link

I know that this file is really big, but, I dont know why I can open it in Notepad++ with hex plugin, for example, and here I cant.
Thanks

@stef-levesque
Copy link
Owner

Unfortunately, it's due to VS Code limitation, see microsoft/vscode#21869

@rodrigokiller
Copy link
Author

rodrigokiller commented Jul 13, 2017

Hello @stef-levesque . I think that it is no more a VS Code limitation. I tried and now I can open files more than ~15MB. I tried a 26 MB file and it opened in VS Code. And, in the link provided by you, alexandrudima could not reproduce the issue and the issue was closed.

@stef-levesque
Copy link
Owner

Thanks to the memory fixes in microsoft/vscode#30180 , the bottleneck is no more coming from memory, but from the time it takes to process the output of hexdump and display the actual TextDocument.

i.e. If you set hexdump.maxLineCount to 1000000, you can't open hexdump on a large file (~15Mb). But if you first open it with the default hexdump.maxLineCount and once it is open, increase hexdump.maxLineCount to 1000000, it will eventually update the already-opened hexdump TextDocument.

I'll take another look, and see if I can provide a limited "preview" before loading the whole file in the background.

@rodrigokiller
Copy link
Author

@stef-levesque thanks Stef, I know that I can use a editor that focus only in the hex edition, but, I really love Visual Code and it would be nice to have an actual good option to those old hex editors.

@stef-levesque
Copy link
Owner

@rodrigokiller version 1.6.0 of this extension should better handle large files. You can try to set hexdump.sizeDisplay to 15728640 for displaying a full 15Mb file, but due to a VSCode limitation, the color syntax won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants