From 0fc557b74544eeb5944759345fa1a4958682ecd1 Mon Sep 17 00:00:00 2001 From: steelbrain Date: Thu, 9 Jul 2015 09:46:03 -0600 Subject: [PATCH 1/3] :fire: Remove an outdated config --- lib/main.coffee | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/main.coffee b/lib/main.coffee index e6e3171c..a4ee8e7f 100644 --- a/lib/main.coffee +++ b/lib/main.coffee @@ -32,12 +32,6 @@ module.exports = title: 'Underline Issues' type: 'boolean' default: true - statusIconPosition: - title: 'Position of Status Icon on Bottom Bar' - description: 'Requires a reload/restart to update' - enum: ['Left', 'Right'] - type: 'string' - default: 'Left' ignoredMessageTypes: title: "Ignored message Types" type: 'array' From b5f1d9e54756949d13cb0c25ee66a60b6a7bc940 Mon Sep 17 00:00:00 2001 From: steelbrain Date: Thu, 9 Jul 2015 09:46:23 -0600 Subject: [PATCH 2/3] :fire: Remove spec about that config --- spec/config/status-icon-position-spec.coffee | 49 -------------------- 1 file changed, 49 deletions(-) delete mode 100644 spec/config/status-icon-position-spec.coffee diff --git a/spec/config/status-icon-position-spec.coffee b/spec/config/status-icon-position-spec.coffee deleted file mode 100644 index d0630c57..00000000 --- a/spec/config/status-icon-position-spec.coffee +++ /dev/null @@ -1,49 +0,0 @@ -BottomTab = require '../../lib/views/bottom-tab' - -describe "The Status Icon Configuration Option", -> - [statusBar, workspaceElement, dummyView] = [] - configString = "linter.statusIconPosition" - - beforeEach -> - workspaceElement = atom.views.getView(atom.workspace) - dummyView = document.createElement("div") - statusBar = null - - waitsForPromise -> - atom.packages.activatePackage('linter') - waitsForPromise -> - atom.packages.activatePackage('status-bar') - - runs -> - statusBar = workspaceElement.querySelector("status-bar") - - it "is 'Left' by default.", -> - expect(atom.config.get(configString)).toEqual "Left" - - describe "when set to 'Left'", -> - beforeEach -> - atom.config.set configString, 'Left' - - it "is set to 'Left.'", -> - expect(atom.config.get(configString)).toEqual "Left" - - it "is on the left side of the Status Bar.", -> - jasmine.attachToDOM(workspaceElement) - [linterHighlight] = statusBar.getLeftTiles().map (tile) -> tile.getItem() - expect(linterHighlight).toBeDefined - [linterHighlight] = statusBar.getRightTiles().map (tile) -> tile.getItem() - expect(linterHighlight).not.toBeDefined - - describe "when set to 'Right'", -> - beforeEach -> - atom.config.set configString, 'Right' - - it "is set to 'Right.'", -> - expect(atom.config.get(configString)).toEqual "Right" - - it "is on the right side of the Status Bar.", -> - jasmine.attachToDOM(workspaceElement) - [linterHighlight] = statusBar.getRightTiles().map (tile) -> tile.getItem() - expect(linterHighlight).toBeDefined - [linterHighlight] = statusBar.getRightTiles().map (tile) -> tile.getItem() - expect(linterHighlight).not.toBeDefined From 7a94c0028c7e4b48dfa62c524c627b5762f3af87 Mon Sep 17 00:00:00 2001 From: steelbrain Date: Thu, 9 Jul 2015 09:47:07 -0600 Subject: [PATCH 3/3] :memo: Document change in CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c62cb899..3cb3e859 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# Upcoming + +* Remove an oudated config (`statusIconPosition`). + # 1.2.3 * Fix a bug where panel won't be hidden even with no errors.