options.timeout need the default value written to config

[leagris]

Issue details

When options.timeout is not set, some commands times-out with:

[Linter] Error running ShellCheck Error: Process execution timed out
    at /home/username/.atom/packages/linter-shellcheck/node_modules/sb-exec/lib/index.js:89

Expected behavior

When options.timeout is not set:

• Use a reasonable default timeout value other than 0.
• Have the default value written back to config.
• Eventually, report an average-human-readable explicit message, that the option is not set and it uses the default value.

Notes

The MDN/WindowOrWorkerGlobalScope.setTimeout(), Parameters documentations says that the default value is 0 milliseconds:

delay Optional

The time, in milliseconds (thousandths of a second), the timer should wait before the specified function or code is executed. If this parameter is omitted, a value of 0 is used, meaning execute "immediately", or more accurately, the next event cycle_. Note that in either case, the actual delay may be longer than intended; see Reasons for delays longer than specified below.

Related issues

• Process execution timed out AtomLinter/linter-shellcheck#110

[steelbrain]

exec/src/helpers.js

Line 26 in 48910bb

if (options.timeout) {

We fill out the default options.timeout if not specified